Uh oh!
There was an error while loading. Please reload this page.
refactor, qt: Nuke some circular dependencies - #17513
Merged
Merged
Conversation
practicalswift
commented
Nov 19, 2019
Contributor
Concept ACK Wow, three nuked circular dependencies in one go! Feels very good to see this suppression list shrink :) |
hebastoforce-pushed
the
20191119-nuke-circular-dep
branch
from
November 19, 2019 11:43
58470e0 to
580937eCompareDrahtBot
commented
Nov 19, 2019
Contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebastoforce-pushed
the
20191119-nuke-circular-dep
branch
2 times, most recently
from
November 19, 2019 11:54
fe054ef to
e27c011Compareinstagibbs
commented
Nov 19, 2019
Member
literally did a subset of this for #17492 concept ACK |
MemberAuthor
Oh, I didn't notice 450a2f7913bfbcfbc9c9dcc03c468043fe86fd76 before... |
instagibbs
commented
Nov 19, 2019
Member
I was later pretty sure, just noting this would help my PR get smaller :) |
Co-authored-by: Gregory Sanders <gsanders87@gmail.com>
Co-authored-by: Gregory Sanders <gsanders87@gmail.com>
hebastoforce-pushed
the
20191119-nuke-circular-dep
branch
from
November 19, 2019 15:07
e27c011 to
5f50599Comparehebasto
commented
Nov 19, 2019
MemberAuthor
@instagibbs has been added as a co-author. |
Sjors
commented
Nov 19, 2019
Member
ACK 5f50599 |
instagibbs
commented
Nov 20, 2019
Member
code review ACK 5f50599 |
practicalswift
commented
Nov 20, 2019
Contributor
ACK 567cb44 -- diff looks correct |
hebasto
commented
Nov 21, 2019
MemberAuthor
You've ACKed non-top commit ;) |
promag
approved these changes
Nov 21, 2019
practicalswift
commented
Nov 21, 2019
Contributor
laanwj added a commit
that referenced
this pull request
Nov 21, 2019
5f50599 refactor: Cleanup headers from walletmodel.h (Hennadii Stepanov) a53e989 refactor: Nuke walletmodel circular dependency (Hennadii Stepanov) 49c4211 refactor: Nuke walletmodeltransaction circular dep (Hennadii Stepanov) 567cb44 refactor: Nuke guiutil circular dependency (Hennadii Stepanov) 73b5505 refactor: Move SendCoinsRecipient in own header (Hennadii Stepanov) Pull request description: This PR gets rid of the following circular dependencies: - `qt/guiutil` -> `qt/walletmodel` -> `qt/optionsmodel` -> `qt/guiutil` - `qt/walletmodel` -> `qt/walletmodeltransaction` -> `qt/walletmodel` - `qt/paymentserver` -> `qt/walletmodel` -> `qt/paymentserver` ACKs for top commit: Sjors: ACK 5f50599 instagibbs: code review ACK 5f50599 practicalswift: ACK 5f50599 -- diff looks correct promag: ACK 5f50599. Tree-SHA512: 070686ac82b5c68c3ef1b8b4c16b4b916b84d80d1e92e42287fdd9454671bea54779c0d2db4db623750aaaf180beaba212137190d6a427113905e2c4be5c60c5
MarkLTZ added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 29, 2019
jasonbcox pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 1, 2020
Summary: Co-authored-by: Gregory Sanders <gsanders87@gmail.com> Backport of Core [[bitcoin/bitcoin#17513 | PR17513]] - Part 1 of 4. Test Plan: `ninja && ninja check` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7572
deadalnix pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 1, 2020
Summary: This is part 3 of 4 for backport of Core [[bitcoin/bitcoin#17513 | PR17513]] Commit [[bitcoin/bitcoin@5f50599 | 5f50599]] Depends on D7602 Test Plan: `ninja && ninja check` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7603
deadalnix pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 1, 2020
Summary: This conclude backport of [[bitcoin/bitcoin#17513 | PR17513]] Commit [[bitcoin/bitcoin@49c4211 | 49c4211 ]] Depends on D7603 Test Plan: `ninja && ninja check` `test/lint/lint-circular-dependencies.sh` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the following circular dependencies:
qt/guiutil->qt/walletmodel->qt/optionsmodel->qt/guiutilqt/walletmodel->qt/walletmodeltransaction->qt/walletmodelqt/paymentserver->qt/walletmodel->qt/paymentserver