Update bdk cli for wasm

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74

[danielabrozzoni]

Description

This PR adds a module to bdk-cli that exposes some structures/functions to WASM. You can see it in use here: bitcoindevkit/bitcoindevkit.org#118

Notes to the reviewers

Based on #116

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[afilini]

I would also add a CI job for wasm (just building the code, no tests) so that we don't forget to keep this updated going forward

[notmandatory]

I added this to the 0.7.0 milestone since it's the next big thing worth making a release for.

[danielabrozzoni]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

[notmandatory]

The code is almost ready (I'm working on fixing the CI), do you think we could squeeze it in the 0.6.0 release? I'd like to have the playground updated as soon as possible, as if you use it nowadays it generates insecure descriptors :)

Hey sorry I just saw this comment. If this one is just about ready to go then probably better to put it in 0.6.0 then have to do a 0.7.0 right after 0.6.0. That sound OK @rajarshimaitra ?

[rajarshimaitra]

Sounds good to me.. If this is almost ready we can push it in 0.6.. I will put in a review too soon..

[rajarshimaitra]

On the initial look the code LGTM.. I just have one conceptual question..

Is there any wasm related technical problem of just using this function here and expose it via bindgen?

bdk-cli/src/handlers.rs

Line 533 in 183e85e

pub(crate)fnhandle_command(cli_opts:CliOpts) -> Result<String,Error>{

All the wallet structures and everything else is created internally within this function, so in theory we won't need to have dedicated wasm related structure definition. That was my motivation behind simplifying the handle_command function to only take a CliOpts which is a structured list of strings, same as command line arguments. So a wasm app can just play the function and depending on what it needs to do pass in corresponding string arguments?

I haven't tried this out myself, so wondering if there's something specific to wasm that doesn't allow us to do that?? The purpose of handle_command is one single function to operate everything bdk-cli..

[afilini]

For sure the type is not compatible with wasm, you can't get a CliOpts directly from wasm.

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

[rajarshimaitra]

Thanks @afilini ya that makes sense.. So there is no easy way to do this without the extra structures.. This one is good to go modulo your comments.. Or can they be added in separate PR and we merge this for the next release?

[danielabrozzoni]

The second issue is that in wasm only the MemoryDatabase is supported, which forces you to use "repl style" commands. handle_command recreates the wallet and the database every time, which means you would have an empty database every time and it would be impossible to create transactions, see the balance, etc.

+1, and also creating the db/blockchain requires creating directories (see prepare_home_dir), and you can't do that on WASM

[rajarshimaitra]

ACK 731dc74