Uh oh!
There was an error while loading. Please reload this page.
feat: Add Multipath descriptor support - #238
Conversation
9d2027d to
c63d511ComparePull Request Test Coverage Report for Build 21787788027Details
💛 - Coveralls |
c63d511 to
1433513Compare- Update wallet initialization/creation to check if external descriptor is multipath for both persisted and non persisted wallets - add error variant for when both multipath and internal descriptors are provided
1433513 to
b03ebc7CompareCodecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #238 +/- ##
==========================================
+ Coverage 10.86% 15.00% +4.13%
==========================================
Files 8 8 Lines 2466 2553 +87 ==========================================
+ Hits 268 383 +115 + Misses 2198 2170 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Concept ACK. Something like: fnbuild_wallet_creator(ext_descriptor:String,int_descriptor:Option<String>,) -> CreateParams{ifletSome(int_descriptor) = int_descriptor {Wallet::create(ext_descriptor, int_descriptor)}elseifis_multipath_desc(&ext_descriptor){Wallet::create_from_two_path_descriptor(ext_descriptor)}else{Wallet::create_single(ext_descriptor)}} |
tvpeter
commented
Jul 29, 2026
Closing this PR in favour of #309 |
Description
This PR enables support for BIP389 multipath descriptors. It uses the existing
external descriptorand verifies whether the provided descriptor is a multipath descriptor. If it is, a wallet will be created using theWallet::create_from_two_path_descriptor()method. If not, the standard wallet creation logic will be applied.Fixes#195
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md