fix(create_tx): enforce single recipient for send_all by 1estart · Pull Request #291 · bitcoindevkit/bdk-cli

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

1estart · 2026-06-21T08:17:00Z

Closes#290

Description

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count.

Now returns an error unless exactly one recipient is provided.

Notes to the reviewers

The fix mirrors the validation logic already present in the silent-payments create_tx branch of the same file, so behavior is now consistent between the two code paths.

Changelog notice

Fixed create_tx --send_all to reject multiple recipients instead of silently using only the first one

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing
I've updated CHANGELOG.md

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR

vadim-anfv

The handlers.rs fix looks good.

As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Previously, passing multiple --to arguments with --send_all would silently drain the wallet to only the first recipient, ignoring the rest. This was inconsistent with the silent-payments create_tx, which already validates the recipient count. Now returns an error unless exactly one recipient is provided

1estart · 2026-06-26T05:26:24Z

The handlers.rs fix looks good.
As discussed in #225 (comment) we're moving away from this style of testing (driving the binary as a subprocess), so I'd suggest not adding tests in this PR and dropping the new test file. We can add proper coverage as a follow up after #278 and #289 are merged.

Understood. I've kept the changes minimal and dropped the test file as suggested. I can add the tests later once the related PRs are merged.

codecov · 2026-06-28T19:57:32Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.21%. Comparing base (c579854) to head (50d248c).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
src/handlers.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #291 +/- ##
==========================================
- Coverage 10.22% 10.21% -0.02% 
==========================================
Files 8 8 Lines 2709 2713 +4 ==========================================
Hits 277 277 - Misses 2432 2436 +4

Flag	Coverage Δ
rust	`10.21% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tvpeter · 2026-06-29T02:51:48Z

ACK 50d248c

vadim-anfv

ACK 50d248c

github-project-automationBot added this to BDK-CLI Jun 21, 2026

vadim-anfv suggested changes Jun 23, 2026
View reviewed changes

1estart force-pushed the fix/send-all-recipient-validation branch from 00d042e to 50d248cCompare June 26, 2026 05:19

tvpeter assigned 1estart Jun 29, 2026

tvpeter added this to the CLI 4.0.0 milestone Jun 29, 2026

tvpeter added the good first issue Good for newcomers label Jun 29, 2026

tvpeter approved these changes Jun 29, 2026
View reviewed changes

vadim-anfv approved these changes Jun 29, 2026
View reviewed changes

tvpeter merged commit 0a771ca into bitcoindevkit:masterJun 29, 2026
7 of 9 checks passed

github-project-automationBot moved this to Done in BDK-CLI Jun 29, 2026

tvpeter mentioned this pull request Jul 20, 2026
Release 4.0.0 #304
Closed
14 tasks