Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Adding paymentUrls to Invoices - #177
Merged
Merged
Conversation
…ment urls returned for an invoice
added new test to make sure payment urls are accessed correctly
…voice is already paid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current bitpay Client class discards the returned paymentUrls parameter for both created and fetched Invoices. This pull request adds support for both, as well as a method to access the currently-returned url types (BIP21, BIP72, BIP72b, BIP73), leaving it flexible for new url types in the future.