-
-
Notifications
You must be signed in to change notification settings - Fork 930
Wrong doc and function signature for 8-bit optim #1261
Copy link
Copy link
Labels
Contributions WelcomeWe welcome contributions to fix this issue!We welcome contributions to fix this issue!DocumentationImprovements or additions to documentationImprovements or additions to documentationOptimizersIssues or feature requests relating to optimizersIssues or feature requests relating to optimizers
Description
Activity
Metadata
Metadata
Assignees
Labels
Contributions WelcomeWe welcome contributions to fix this issue!We welcome contributions to fix this issue!DocumentationImprovements or additions to documentationImprovements or additions to documentationOptimizersIssues or feature requests relating to optimizersIssues or feature requests relating to optimizers
System Info
NA
Reproduction
Argument
optim_bitsandamsgradis not used for 8-bit Adamhttps://github.com/TimDettmers/bitsandbytes/blob/dada530149212d64d4b69534716202659ef37ec8/bitsandbytes/optim/adam.py#L77-L95
The document for
optim_bitsis also wrong in this case, because we are using 8 bits here.https://github.com/TimDettmers/bitsandbytes/blob/dada530149212d64d4b69534716202659ef37ec8/bitsandbytes/optim/adam.py#L107-L110
I'm thinking of 2 ways to solve this:
optim_bitsandamsgradarguments (actually even 32-bit Adam also doesn't useamsgradargument)optim_bits == 8andamsgrad == FalseExpected behavior
NA