Fix PytorchLARS updates when momentum is zero - #2082
Open
mottopanikeiku wants to merge 1 commit into
Open
mottopanikeiku wants to merge 1 commit into
mottopanikeiku wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2079.
I use the weight-decayed gradient when
PytorchLARShas zero momentum, keeping the existing update-norm limit. This fixes the defaultstep()crash and prevents a zero-momentum group from reusing the previous parameter's momentum update. The native LARS variants are unchanged.Validation on CPU with Python 3.12 and PyTorch 2.8.0+cpu:
OMP_NUM_THREADS=2 python -m pytest tests/test_optim.py -k lars -q: 10 passed, 4 existing bfloat16 skips.pre-commit run --all-files: all hooks passed.I used OpenAI Codex for investigation, implementation, and testing. This has been manually reviewed.