Null field from json deserialization fix - #37
Merged
Merged
Conversation
scr
commented
Feb 23, 2017
Collaborator
👍 |
scr
commented
Feb 23, 2017
Collaborator
Can you please add a note in https://github.com/bivas/protobuf-java-format/blob/master/RELEASE-NOTES.md - this is still manually generated - This would be a fix added in 1.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this moment deserialization from json differs in case when filed is omitted or equals to null.
{}deserializes to empty object when{"field":null}is deserialized to object with empty object for "field"After this fix both json are deserialized to empty object