feat: remove to_sentence usage by ThomasCrambert · Pull Request #534 · bkeepers/dotenv

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍

ThomasCrambert · 2025-07-09T09:00:14Z

Hello 👋,

While introducing this gem within our codebase, we studied the boot time impact as it increased by 400ms. We tracked down an increase of 200ms from this gem at

dotenv/lib/dotenv/log_subscriber.rb

Line 27 in 91d98f0

debug"Set #{changed.to_sentence}"ifdiff.any?

, trying to load I18n. We found out it's because of a call to #to_sentence that under the hood calls I18n.translate (cf https://github.com/rails/rails/blob/main/activesupport/lib/active_support/core_ext/array/conversions.rb#L69).

Since these are simple debug logs, I changed them to simple .join(' ). Is that fine for you

bkeepers · 2025-07-09T11:10:28Z

Thanks @ThomasCrambert, I'll get a release out soon.

fatkodima · 2025-07-28T11:26:25Z

@bkeepers Please make a new release with this change.

ThomasCrambert · 2025-09-24T15:23:55Z

Hello @bkeepers 👋, could you make a new release that would contain this change? It's been quite a while since the last one 🙏

bkeepers · 2025-12-03T16:29:16Z

@ThomasCrambert v3.2.0 is out with this change. Sorry for the delay.

franzliedke · 2025-12-04T06:38:52Z

 diff = event.payload[:diff]
 changed = diff.env.keys.map { |key| color_var(key) }
- debug "Set #{changed.to_sentence}" if diff.any?
+ debug "Set #{changed.join(", ")}" if diff.any?


Suggested change
debug"Set #{changed.join(", ")}"ifdiff.any?
debug{"Set #{changed.join(", ")}"}ifdiff.any?
This could be another improvement when the log level is to something less verbose, right?

I think these are usually called only once (on boot) and does not matter.

Alright, the PR made me think it's called multiple times. But apparently the slowdown came just from booting i18n. 😬

But apparently the slowdown came just from booting i18n.
Yes that's the reason why I proposed this change. Dotenv shouldn't have any impact post-boot 👍