New credits item count - #373
Closed
nn357 wants to merge 5 commits into
Closed
Conversation
todo: sum the nothings / not placed and write them to rom should be complete: item count addition on item collection, newgame with starting items increases number, credits displayed as a fraction is not 100 items placed.
otherwise it displays as 0/00 due to nothings being placed everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this uses collecting an item plm to increase a counter.
if less than all items are placed it displays the items collected / items placed as a fraction.
it should handle starting items + non desolate (i.e 3 nothings + 3 starting items) = % display not fraction.
there are probably some edge cases I didn't catch while testing.
have tried several combinations of stop item placement, with / without starting items etc.
this also removes the need to shadow the bits during escape etc as the calculations are done on the new collected counter not what's equipped.