fix: open saved agent after creation - #137
Merged
Merged
Conversation
kalvinnchau
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Saving a newly created agent now opens its profile immediately, and the profile shows a readable Description label.
Problem: Finishing the agent creation flow left users in the builder instead of taking them to the agent they had just saved. The profile could also expose the internal
view.descriptiontranslation key rather than a user-facing label.Solution: Route successful agent promotions directly to the saved agent profile and seed the promoted source into the agent store before navigation, so the destination remains available even when the follow-up disk refresh is delayed or fails. Add a readable fallback for the description label and regression coverage across the completion callback chain.
File changes
src/app/AppShell.navigation.test.tsx
Covers the app-level transition from an active agent builder to the saved agent detail route.
src/app/AppShell.tsx
Handles agent builder completion by navigating directly to the saved agent profile.
src/app/ui/AppShellContent.tsx
Carries the completion callback from the app shell into the chat surface that hosts the builder.
src/features/agents/capabilities/AgentBuilderCapability.tsx
Seeds the promoted agent into the store, signals completion immediately, and leaves disk refresh as background reconciliation so navigation stays reliable.
src/features/agents/ui/AgentDetailPage.tsx
Adds a readable fallback for the Description metadata label.
src/features/agents/ui/tests/AgentsView.entry.test.tsx
Verifies the readable Description label and its conditional visibility.
src/features/chat/ui/ChatRightRail.tsx
Forwards builder completion from the agent capability toward app navigation.
src/features/chat/ui/ChatView.tsx
Connects the chat-hosted builder completion callback to the app shell.
src/features/chat/ui/tests/ChatRightRail.test.tsx
Covers promotion, immediate store seeding, navigation signaling, successful reconciliation, and refresh failure behavior.
src/features/chat/ui/tests/ChatView.mcpApp.test.tsx
Verifies the completion callback is preserved through the ChatView boundary.
src/shared/api/agents.ts
Exports and reuses the canonical agent-source-to-persona mapping for immediate store seeding.
Reproduction steps
view.description.