Conversation
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
mahanti
force-pushed
the
codex/pulse-message-bubbles
branch
from
September 14, 2026 15:09
5040b1c to
c9447c8
Compare
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
mahanti
marked this pull request as ready for review
September 16, 2026 14:19
mahanti
requested review from
a team,
comp615 and
wesbillman
as code owners
September 16, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel and thread messages render as rounded, directional bubbles using the shared Buzz design system. The viewer’s messages align right; incoming messages align left. Adjacent messages from the same author group within ten minutes, with new groups at local midnight and across membership events, and an avatar on the final incoming message.
Screenshots
Standalone preview screenshots from the styling iteration, with sample content. Light/dark examples show the reply action; the narrow example includes typing and delivery feedback. The combined reaction/reply toolbar is exercised in the live app and reaction browser fixture.
Compatibility and validation
Updated against main at
a9194b2, preserving link previews, receive-only typing, sized media, rich composer editing, and thread navigation. Bubble styles are scoped to message rows so composer tokens retain their normal geometry and literal fallback messages preserve line breaks.The existing Virtua React ESM patch defers only new row observation begun synchronously during resize delivery. This avoids WebKit same-depth observer-loop errors while retaining ordinary mount timing, adaptive estimates, size updates and scroll correction behavior. Lifecycle tests cover early unmount, cancellation, hidden/reassigned rows, remount, and subscriber errors.
The timeline preserves initial bottom intent through cold measurement and explicit reading intent through transient extent clamping. It captures the settled visible message before leaving, including when virtual rows mounted after the last scroll event. Revisiting a conversation keeps that message in place; the first real gesture takes control immediately, and deliberately returning to the bottom resumes following.
Review status
Conflicts are resolved. All hosted checks pass at
dfd28b5: CI required (JavaScript, Rust/tool integration, Windows, browser measurements and all four browser journey shards), DCO, Semgrep, and zizmor. All seven PR commits have DCO sign-offs. Ready for review; required reviewer/code-owner approval is still needed before merging.