Honor macOS title bar double-click setting - #76
klopez4212 wants to merge 1 commit into
Conversation
Signed-off-by: klopez4212 <klopez4212@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74c120cf0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,64 @@ | |||
| import type { MouseEventHandler } from "react"; | |||
There was a problem hiding this comment.
The reviewed commit has no Signed-off-by trailer, so it violates the repository's DCO requirement and will fail the hosted DCO Check. Ensure this commit carries the verified author's sign-off while preserving its actual authorship before integration.
AGENTS.md reference: AGENTS.md:L123-L126
Useful? React with 👍 / 👎.
| start?.x !== event.clientX || | ||
| start.y !== event.clientY |
There was a problem hiding this comment.
When the pointer moves by even one CSS pixel between the second mouse-down and mouse-up, these exact coordinate comparisons suppress the configured title-bar action even though event.detail === 2 shows that the platform accepted the interaction as a double-click. Normal hand jitter therefore makes Fill/Zoom or Minimize unreliable; use a small drag threshold or native double-click detection rather than requiring perfectly stationary coordinates.
Useful? React with 👍 / 👎.
Summary
Validation
origin/main