Cannot leave a community whose relay already ended my membership (403 → 'Relay session is terminal')

[issamsultan]

Buzz Desktop version: 0.5.19 (macOS, Darwin 25.6.0)

Summary

When a relay has already ended my membership server-side, the desktop app cannot remove that community locally. The "Leave community" flow requires the relay to accept the leave event first (per #3621), but the relay refuses the connection entirely — so the leave can never succeed and the dead community is stuck in the community switcher permanently.

Steps to reproduce

1. Be a member of a community, then have your membership ended on the relay side (removed by the owner / membership expired).
2. The sidebar for that community shows: relay returned 403 Forbidden: You must be a relay member to access this relay.
3. Open the community switcher → hover the community → Leave community.
4. The action is blocked with: Relay session is terminal; cannot reconnect.

Expected

If the relay reports the session is terminal / membership already ended (403 relay_membership_required), local removal should proceed anyway — there is no membership left to end, so requiring relay acceptance is a chicken-and-egg dead end.

Actual

"Leave community" never completes; the community cannot be removed from the local list. Updating to 0.5.20 does not change this (no related fix in the release notes).

Notes

#3621 deliberately keeps the community in place on relay rejection, which is correct for transient errors — but a terminal/403-membership response is not transient and should be treated as "already left".

[adrianmross]

Related case that #7097 doesn't cover: the relay is unreachable rather than rejecting (host gone, DNS dead, VPN down for good). leaveCommunity first calls relay_requires_membership (GET /info), which fails with relay unreachable: … before any leave request can be sent, so the community is stuck in the switcher with no way out.

Proposal: keep #3621's rule that leaving requires relay acceptance, but when the failure is specifically isRelayUnreachableError, show a secondary Remove from this device action under the error. It removes the community locally and tells the person their membership was not revoked. Rejections from a relay that answered (auth failures, terminal sessions, etc.) never show it.

This complements #7097 (relay reachable, membership already ended) rather than overlapping it. Happy to open a PR if a local-only escape hatch for that case fits the direction after #3621.