Skip to content

test(db): make replica_fence boundary assertions clock-resolution portable #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s00ly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(db): make replica_fence boundary assertions clock-resolution portable #2269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions crates/buzz-db/src/replica_fence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,20 @@ mod tests {

let ts = Utc::now();
fence.advance(ts);
assert_eq!(fence.verified_through(), Some(ts));
// advance() normalizes to Postgres timestamptz resolution (micros);
// compare at that resolution so the assertion is clock-precision
// portable (Utc::now() yields nanos on Linux, micros elsewhere).
assert_eq!(
fence.verified_through(),
DateTime::from_timestamp_micros(ts.timestamp_micros())
);
assert!(fence.covers(ts - chrono::Duration::seconds(1)));
assert!(fence.covers(ts), "boundary is inclusive");
// Inclusive boundary at the fence's resolution: the exact micros
// watermark is covered (raw nanos `ts` is strictly past it).
assert!(
fence.covers(DateTime::from_timestamp_micros(ts.timestamp_micros()).unwrap()),
"boundary is inclusive"
);
assert!(!fence.covers(ts + chrono::Duration::seconds(1)));

fence.close();
Expand Down
Loading