Skip to content

fix(desktop): preserve channel intro action focus rings #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mclawd-lgtm wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(desktop): preserve channel intro action focus rings #2430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion desktop/src/features/messages/ui/ChannelIntroBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ export function ChannelIntroBlock({
</p>
) : null}
{intro.actions?.length ? (
<div className="mt-4 flex max-w-full flex-nowrap gap-3 overflow-x-auto pb-1">
<div
className="-mx-1 mt-3 flex max-w-[calc(100%+0.5rem)] flex-nowrap gap-3 overflow-x-auto p-1"
data-testid="message-channel-intro-actions"
>
{intro.actions.map((action) => {
const hasDescription = Boolean(action.description);

Expand Down
5 changes: 5 additions & 0 deletions desktop/tests/e2e/channels.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,6 +1507,11 @@ test("empty channel shows intro actions", async ({ page }) => {
await expect(page.getByTestId("welcome-composer-guide-banner")).toHaveCount(
0,
);
// Horizontal scrolling creates a clipping context. The padded, offset row
// leaves space for the cards' focus rings without changing their alignment.
const introActions = page.getByTestId("message-channel-intro-actions");
await expect(introActions).toHaveCSS("padding-top", "4px");
await expect(introActions).toHaveCSS("padding-bottom", "4px");
await expectIntroActionCardLayout(page, "channel-intro-action-create-agent");
await expectIntroActionsShareRow(page, [
"channel-intro-action-create-agent",
Expand Down