feat(desktop): autocomplete ACP slash commands - #2653
kevinmanase wants to merge 2 commits into
Conversation
d8321ea to
3f63a36
Compare
|
We'd like to see this land, so we did a full review of this PR against today's Review findingsStrengths:
Gaps worth follow-ups (not blockers in our view):
What the rebased branch addsAll feature credit to @kevinmanase; we started from the conflict resolutions in #3537 (thanks to its author too) and brought it the rest of the way:
Related work, for cross-reference: this implements #2528 and also covers the ask in #5741; #6567 builds the picker-chip UI for the same space but without persistence or the typed- Happy to open the rebased branch as a fresh PR, or hand it off however is easiest — whichever the maintainers prefer. |
Signed-off-by: kevb10 <gasydev@gmail.com>
Isolate command catalogs by community, reject malformed snapshots, and reuse the current mention bindings so duplicate names keep the selected recipient. Respect code contexts and composition, and cover persisted commands through browser selection and message signing. Signed-off-by: kevb10 <gasydev@gmail.com>
3f63a36 to
aef61fa
Compare
🔐 Codex Security Review
|
|
thanks for the review @rshiozaki. i've rebased onto current main, resolved the conflicts, and pushed another simplification and review pass here. i'm continuing the work in this original pr, so let's keep the review here. fixed the control/bidi gap, community scoping, and duplicate-name recipient handling. added browser coverage for selecting a command and checking who the signed message addresses. the owner-only catalog limitation and multiple-mention behavior are now in the description. full local ci passed against @wesbillman @wpfleger96 @klopez4212 would appreciate another look when you get a chance. could one of you approve the fork ci run and authorize the current head using the security-review bot's instructions? |
summary
adds slash-command autocomplete for commands advertised by acp agents. typing
/at the start of a message groups suggestions by agent; selecting one inserts its exact mention and command. typing after leading agent mentions filters to those agents and preserves the existing mentions.rebased onto current
mainand adapted to the current observer batching, composer focus handling, and autocomplete overlays. the follow-up pass reuses the shared mention parser, isolates catalogs by community and owner, rejects control/bidi characters, and respects code blocks and ime input. no file-size override is needed.behavior and scope
testing
CHECK_FILE_SIZES_BASE=upstream/main just ci: passed. the explicit base avoids comparing against the fork's olderorigin/main. desktop typecheck also passed.fixes #2528