feat(desktop): surface tool-permission asks as thread-reply cards (#4938) - #5106

Open

wpfleger96 wants to merge 87 commits into

mainfrom

duncan/permission-policy

Commits on Aug 6, 2026

feat(acp): implement permission policy (#4938)

Duncan
and
wpfleger96
committed
127298f
feat(desktop): permission policy config + actionable Allow/Deny card (#4938)

Hayt
and
wpfleger96
committed
d8be338
fix(desktop): control_result is delivery confirmation, not terminal outcome

Hayt
and
wpfleger96
committed
90e3292
Merge remote-tracking branch 'origin/hayt/permission-policy' into duncan/permission-policy
Duncan
committed
4f72c3c
feat(acp): add PermissionMode::Auto + contradiction matrix rows (#4938)

Duncan
and
wpfleger96
committed
6dbbc67
fix(acp): address Thufir pass-1 CRITICAL and IMPORTANT findings (#4938)

Duncan
and
wpfleger96
committed
b3b1b3b
fix(acp): address Thufir pass-2 review findings (#4938)

Duncan
and
wpfleger96
committed
96538e9

Commits on Aug 7, 2026

fix(acp): structural round — one nonce-keyed permission record, finish_permission() helper

Duncan
and
wpfleger96
committed
6607eaf
fix(acp): address Thufir pass-4 review findings

Duncan
and
wpfleger96
committed
7d277da
fix(buzz-acp): thread single nonce through sync denial paths; upgrade two tests to pipe-level proof

Duncan
and
wpfleger96
committed
73f2ffe
test(buzz-acp): tighten equality-deadline test to pinned future + exact payload

Duncan
and
wpfleger96
committed
fcd33ff
refactor(desktop): extract permission/transcript types to fix file-size ratchet

Duncan
and
wpfleger96
committed
bcd9bac
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
fe901d8
refactor(desktop): extract RawManagedAgent/fromRawManagedAgent to managedAgentMapping.ts

Duncan
and
wpfleger96
committed
2dd0706
fix(desktop): use struct literal init to satisfy clippy::field_reassign_with_default

Duncan
and
wpfleger96
committed
e87f265

Commits on Aug 8, 2026

feat(desktop): render permission-request sentinel card in thread timeline

Hayt
and
wpfleger96
committed
cef78d7
feat(acp): publish kind-9/40003 permission sentinel cards into channel thread

Duncan
and
wpfleger96
committed
d808c4b
Merge remote-tracking branch 'origin/main' into duncan/permission-policy

Duncan
and
wpfleger96
committed
74c9200
fix(acp): restore correct merge resolution for buzz-acp post-main-revert

Duncan
and
wpfleger96
committed
1e0c5ba
fix(desktop): parse bare-JSON sentinel, unify expiry clock, tighten guards, add component tests

Hayt
and
wpfleger96
committed
a16b059
fix(acp): ACK-gated sentinel lifecycle, D7 admission, NIP-AO docs

Duncan
and
wpfleger96
committed
fe7efd8
test(desktop): add harness integration fixture test for kind-9 parser

Hayt
and
wpfleger96
committed
3129900
fix(acp): background task owns ACK-waiter expiry, add 3 missing named tests

Duncan
and
wpfleger96
committed
ef67355
refactor(acp): delete publish_event_acked, only register_publish_ack is live

Duncan
and
wpfleger96
committed
aeca230
fix(desktop): sentinel-only edit gate in formatTimelineMessages; reword card doc

Hayt
and
wpfleger96
committed
f858cab
test(e2e): align permission outcome assertion with label-based rendering

Hayt
and
wpfleger96
committed
60c247e

Commits on Aug 10, 2026

chore: merge origin/main into duncan/permission-policy

Duncan
and
wpfleger96
committed
ff5b21f
fix(desktop): fail-closed PermissionDecisionButtons for allow_always and unknown kinds

Hayt
and
wpfleger96
committed
3ad999a
fix(acp): add permission_decision_tx: None to main's new test TaskMeta inits

Duncan
and
wpfleger96
committed
bac3264
fix(desktop): persist applied permission policy for remote deploys

Duncan
and
wpfleger96
committed
00456e4
fix(desktop): exact-allowlist permission kinds, disclose persistent deny

Hayt
and
wpfleger96
committed
ca9acfa
fix(desktop): enforce deploy-receipt invariant for applied permission policy

Duncan
and
wpfleger96
committed
0bc5683

Commits on Aug 12, 2026

feat(desktop): relocate permission-policy default to the agent definition

Duncan
and
wpfleger96
committed
f4efd99
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
f1ab873

Commits on Aug 25, 2026

Merge remote-tracking branch 'origin/main' into duncan/permission-policy

Duncan
and
wpfleger96
committed
3c0dfd7
Merge remote-tracking branch 'origin/main' into duncan/permission-policy

Duncan
and
wpfleger96
committed
1725f16
chore(desktop): reclaim file-size headroom via comment trims

Duncan
and
wpfleger96
committed
bf411ef
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
9d42119
refactor(desktop): extract spawn helpers and reshape permission card props

Duncan
and
wpfleger96
committed
25ddb2f
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
d9bed35
chore(desktop): reclaim file-size headroom for permission-policy fields

Duncan
and
wpfleger96
committed
6aa3315
test(desktop): keep pending policy true in failed-deploy setup

Duncan
and
wpfleger96
committed
8672302
test(desktop): expect seeded permissionPolicy in access-override edit case

Duncan
and
wpfleger96
committed
d4417a9
fix(acp): freeze permission card to a two-action contract

Duncan
and
wpfleger96
committed
e6014be
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
30bb1f8
docs(nip-ao): align sentinel spec with two-action card contract

Duncan
and
wpfleger96
committed
6e7c697
fix(acp): unify sentinel byte bounds across producer and parser

Duncan
and
wpfleger96
committed
926a021
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
a183f25
fix(acp): gate sentinel total-content bound on raw content before trim

Duncan
and
wpfleger96
committed
05566b9
docs(acp): correct total-content gate rationale for control-char inflation

Duncan
and
wpfleger96
committed
4a8305c

Commits on Aug 26, 2026

Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
422e336
fix(acp): bound Publishing entries and require edit provenance for resolved cards

Duncan
and
wpfleger96
committed
0b967b5
test(acp): make publish-in-flight regression production-shaped

Duncan
and
wpfleger96
committed
8538058
refactor(acp): bundle ask-only preflight gates into AskGates

Duncan
and
wpfleger96
committed
7bb2982

Commits on Aug 27, 2026

Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
1a19de3
fix(acp): retransmit resolved permission edit until relay accepts it

Duncan
and
wpfleger96
committed
018095e
fix(acp): bound resolved-edit retransmit per attempt, not per card

Duncan
and
wpfleger96
committed
37103a6

Commits on Aug 28, 2026

fix(acp): close inbound permission-decision lifecycle gap

Duncan
and
wpfleger96
committed
5916529
Merge remote-tracking branch 'origin/main' into duncan/permission-policy

Duncan
and
wpfleger96
committed
111bc91
fix(desktop): survive rejected send in permission retransmit loop

Duncan
and
wpfleger96
committed
247f897
fix(desktop): propagate control_result status; failure re-enables card for retry

Duncan
and
wpfleger96
committed
77f7440
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
ecd441b
test(desktop): add delivery-seam + component regression test for failed-outcome recovery

Duncan
and
wpfleger96
committed
9301abf
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
2787c55

Commits on Aug 29, 2026

fix(acp): correct verb derivation, add description field, fix forged-sentinel prose suppression

Duncan
and
wpfleger96
committed
2f95fca
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
8101c31
fix(acp): extract description from real producer shapes; delegate prose-suppression to computePermissionRequest

Duncan
and
wpfleger96
committed
05246f6

Commits on Aug 30, 2026

fix(acp): extend description extraction to codex v1.1.7; protect prose gate with integrated render test

Duncan
and
wpfleger96
committed
05b496e
fix(acp): clippy borrow and MessageRow memo gaps for permission gate

Duncan
and
wpfleger96
committed
255ed62

Commits on Sep 1, 2026

Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
ed3a25c
fix(acp): implement Carl review findings F1–F4 with full behavioral tests

Duncan
and
wpfleger96
committed
aa30ce6
fix(acp): implement expanded findings F1-F4 + routing hazard

Duncan
and
wpfleger96
committed
d70558f
fix(acp): close Thufir addendum gaps — unconditional first attempt, interactive delivery-seam test

Duncan
and
wpfleger96
committed
242dbf2
chore(desktop): reclaim ratchet headroom — extract duplicate types, compact test fixtures

Duncan
and
wpfleger96
committed
3d925ef
fix(desktop): restore extract_applied_permission_policy lost in merge, fix test callers

Duncan
and
wpfleger96
committed
d5343ef
fix(desktop): correct display_name in content_matches_nip_ap_vector compaction

Duncan
and
wpfleger96
committed
00a04c1
test(acp): fix bounded-exit test — small-step advance for cross-task channel interleaving

Duncan
and
wpfleger96
committed
e5fb508
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
b144047
fix(acp): correct wrapper-overhead and test structure for F1/F3 regressions

Duncan
and
wpfleger96
committed
c23daf8
test(buzz-acp): strengthen pass-2 acceptance proofs for F1–F4 and routing

Duncan
and
wpfleger96
committed
9628c1e
test(buzz-acp): close pass-3 gaps for F1/F3/F4 and MINOR desktop wording

Duncan
and
wpfleger96
committed
96c9b7f
test(buzz-acp): assert reject option ID in reject_once applied write

Duncan
and
wpfleger96
committed
fbeb9fa
fix(acp): scope permission-card retirement to terminating turn; fix fan-out false-ack

Duncan
and
wpfleger96
committed
5c8ec7a

Commits on Sep 2, 2026

fix(acp): treat channel_full as transient; fix legacy-key retirement with colon-bearing sessionId

Duncan
and
wpfleger96
committed
a0309cd
fix(acp): classify channel_full as transient in transcript reducer

Duncan
and
wpfleger96
committed
9659800
Merge remote-tracking branch 'origin/main' into duncan/permission-policy
Duncan
committed
51486b2
docs(agents): enumerate authoritative delivery-failure statuses in stale comments

Duncan
and
wpfleger96
committed
2e2f4df