Conversation
12e1e78 to
1f9c2ff
Compare
|
Rebased onto the latest No review comments on this PR. CI will verify the build and test gate. |
1f9c2ff to
9f0c62d
Compare
🔐 Codex Security Review
|
|
Rebased onto the latest Still-needed assessment: No upstream commits in the 62-commit window address the same issue. This PR remains needed. Review requests: |
9f0c62d to
50bc7a1
Compare
|
Rebased onto current Still needed: Checked all 38 new upstream commits for overlap with this PR's topic. None of the upstream changes address the issue this PR fixes. The PR remains relevant. Verification:
|
50bc7a1 to
8857a7d
Compare
Rebase and review — 2026-09-03Base commit: Accuracy review: The Continue button is still not shown when a raw nsec is loaded in the backup restore dialog. |
8857a7d to
dfb66df
Compare
Rebase and review update — Sep 3, 2026Rebased onto latest main ( Accuracy review: Main's backup restore dialog does not show a Continue button when a raw nsec is loaded. The Mergeable status: Confirmed MERGEABLE on GitHub after force-push. |
dfb66df to
0800e85
Compare
Rebase pass — Sep 5, 2025Rebased onto current upstream main ( Rebase resultRebased cleanly onto current main. No conflicts. Still-needed assessmentChecked all 62 new main commits for overlap with this PR's topic. None obsoleted:
Verification
|
0800e85 to
60997ea
Compare
Rebase pass — Sep 9, 2026Rebased onto current upstream main ( Rebase resultRebased cleanly onto current main. No conflicts. Still-needed assessmentChecked all 8 new main commits for overlap with this PR's topic. None obsoleted. None of the 8 new main commits touch the key-import form's Continue gating. Verification
|
…estore dialog
The backup-file restore dialog (mode="backup") accepts .key files
containing a raw nsec1 key. The file parser loads the key and shows
"Nostr identity found" with the derived npub, but the submit button
only rendered when mode === "key" or isPasswordStage (ncryptsec). A
raw nsec in backup mode satisfies neither condition, so the user sees
a recognized identity with no forward action — a dead end.
Add isValid to the render guard so a valid raw nsec shows the Continue
button regardless of mode. The button's disabled={!isValid} check
already prevents submission of invalid input.
Closes block#5261.
Co-authored-by: Brad Groux <brad@digitalmeld.com>
Signed-off-by: Brad Groux <brad@digitalmeld.com>
Signed-off-by: dm-builder <f01486f036641ccb52c11bb1e0ff2346ea89a8b4e3b49cd772249948f6fcbae6@digitalmeld.communities.buzz.xyz>
Signed-off-by: Brad Groux <bradgroux@hotmail.com>
Signed-off-by: Brad Groux <3053586+BradGroux@users.noreply.github.com>
60997ea to
59f8056
Compare
Rebase pass — Sep 16, 2026Rebased onto current upstream main ( Rebase resultConflict resolved in desktop/src/features/onboarding/ui/MachineOnboardingFlow.tsx — upstream's onboarding refresh (#7528, #7659) replaced the overlay Dialogs with inline key-import pages. Kept upstream's new inline structure and re-applied this PR's copy changes (Import from a file heading, import-from-file button, and the broader file-description wording) to the new backup sub-page. The core isValid render guard in NostrKeyImportForm.tsx applied cleanly. Still-needed assessment#7528 (refresh onboarding flow) and #7659 (fix onboarding regressions) rewrote the surrounding flow but the raw-nsec Continue gap is still present on main: mode === "key" || isPasswordStage still gates the submit button without isValid. Verification
What was not doneNo local test suites were run. The rebase only repositions commits; conflict resolutions carry the same logical changes forward (CI will verify builds). |
Summary
The backup-file restore dialog accepts
.keyfiles containing a rawnsec1private key. The file parser loads the key and displays "Nostr identity found" with the derived npub, but the submit button only rendered whenmode === "key"orisPasswordStage(ncryptsec). A raw nsec inmode="backup"satisfies neither condition, so the user sees a recognized identity with no Continue button — a dead end with no forward action.Add
isValidto the submit button's render guard so a valid raw nsec shows the Continue button regardless of mode. The button's existingdisabled={!isValid}check prevents submission of invalid input, andkeyImportSubmitEnabledalready validates the nsec by deriving its npub.Related issue
Fixes #5261.
Testing