fix(desktop): refine sidebar motion - #6690
kursmark-sq wants to merge 2 commits into
Conversation
Co-authored-by: Matt Kursmark <kursmark@squareup.com> Signed-off-by: Matt Kursmark <kursmark@squareup.com> Co-authored-by: Codex <noreply@openai.com>
Chessing234
left a comment
There was a problem hiding this comment.
the e2e now expects a single 240ms duration, but two siblings still transition width/left. if --motion-duration-standard isn't 240 this test is the only thing pinning it — please assert the css var or keep the durations you actually animate.
Co-authored-by: Matt Kursmark <kursmark@squareup.com> Signed-off-by: Matt Kursmark <kursmark@squareup.com> Co-authored-by: Codex <noreply@openai.com>
|
🤖 Updated by Fizz. The E2E now collects and pauses the complete coordinated transition: gap Addressed in |
|
@Chessing234 can we move this forward? |
Chessing234
left a comment
There was a problem hiding this comment.
durations now come from the css token and the midpoint hit-test covers gap/panel/opacity together. good.
Summary
Why
The previous top-origin scale pulled nav links upward during collapse, creating unnecessary visual noise. The simultaneous translation added more spatial motion while the sidebar chrome was already sliding away. Keeping the fade preserves the anti-ghosting behavior without moving or shrinking the navigation content.
Before / after
Left: before. Right: after.
Normal speed
4× slower
Test plan
The full local repository gate reaches the existing
buzz-terminalPTY fixturedefault_prog_child_observes_the_login_argv0, which times out waiting for$0in this environment. This is unrelated to the desktop CSS/test-only change and is the same local fixture timeout documented on #6314.