Conversation
The home feed poll pauses while the window is unfocused (block#5490), and Pulse @mentions (kind 1) are feed-driven: with the poll paused, the notification pipeline never saw them, so no native notification and no Home/Mention badge appeared until the user refocused the app. Approval requests and reminders already had an exception: an always-on live #p subscription that triggers a home-feed refetch when a matching event arrives over the WebSocket. Add kind 1 to that subscription so a Pulse mention refreshes the feed — and flows into the existing badge and desktop-notification pipeline — the moment it arrives, without resuming any background polling. The filter is extracted into buildHomeFeedLivePTagFilter() with regression tests. Fixes block#6276 Signed-off-by: mdschoff <mdschoff@gmail.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #6276: Pulse
@mentionsproduce no native desktop notification and no Home/Mention badge while the Buzz window is open but unfocused.Mention alerts are feed-driven:
use-feed-desktop-notifications.tsonly sees a mention when the home feed query returns it. #5490 (intentionally, for CPU/power) switched the home feed touseFocusedRefetchInterval(...), pausing polling on blur — so feed-driven mentions are silenced exactly when the user is working in another app. The #5490 review carved out an exception for reminders and approvals (useLiveHomeFeedActions: an always-on live#pWebSocket subscription that triggers an imperative feed refetch), but Pulse mentions (kind 1) were not included.How it was implemented
KIND_TEXT_NOTEto the existing always-on live#psubscription indesktop/src/app/useLiveHomeFeedActions.ts. A Pulse note p-tagging the user now arrives over the WebSocket (which stays connected regardless of focus) and triggers the samehomeFeedQuery.refetch()the reminder/approval exception already uses; the refetched feed flows into the existing badge and desktop-notification pipeline.buildHomeFeedLivePTagFilter()with regression tests documenting the constraint, so the Pulse kind can't be silently dropped later.How to test manually
ptag for the signed-in user.No UI changes — behavior-only, so no screenshots.
Verification
desktop: pnpm test— 5,802 pass (3 new)desktop: pnpm typecheck, biome check,pnpm build— cleanRelated
Searched open PRs — none found addressing this. #5490 is the (intentional) origin of the regression; this follows the exception pattern its review established for reminders. Sibling PR #7123 fixes the separate active-channel suppression bug in the same notification area.