Conversation
Bind explicit Start permission before preflight and release it only after child registration. Reuse ordinary platform-specific pair Stop and refuse success for an unscoped live legacy child. Signed-off-by: Logan Johnson <loganj@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote Stop 2/5 — 390 changed lines
All existing local spawn paths consult the same owner/community-scoped SQLite fence. Only explicit Start captures release permission before preflight; restore/config/reconcile/Restart cannot. Release occurs after receipt + child tracking. Pair control reuses ordinary Desktop platform teardown. An unscoped live legacy PID fails honestly rather than being erased or claimed stopped. Incoming admission is the next dependency.
Draft status and validation
Part of the dependent Multiverse Remote Stop stack on #7333. Not merge-ready or deployed. Ordinary host Stop only; Start/Restart/Move placement and launch-side broker integration remain follow-on work. No native two-Desktop acceptance has been performed.
Aggregate candidate
9ce501a671822cf6c8511a0c3687aad8eb56acb7: full Desktop JS 6,255 passed; full native 3,171 passed, 19 ignored, plus 7 CSP and 3 mixer integration tests; Desktop production build passed (OSS feature variant, not a normal internal release DMG). Workspace/all-target Clippy, Rust/Tauri formatting, Desktop static checks and web checks passed in the aggregatejust ciattempt.just ciis incomplete: isolated mobile dependency resolution cannot reach pub.dev; no broad-green claim. Static code review was performed directly; no independent human approval claimed.Relay/DB validation on exact aggregate product head
9ce501a6passed all 343 selected PostgreSQL tests, including private storage/query, exact stored request redelivery only to authenticated owner/correct community, and populated migration upgrade. Database discovery guard passes. Two unrelated full-package failures also reproduce at unchanged parent08fbf9c9: relay mesh echo returns 504 rather than 200, and DB observability source guard finds.fetch_all(pool). No weakening/repair of those checks is included.Originating conversation: buzz://message?channel=f45d3304-dcf0-44e8-a46d-bcd63b235fbc&id=46556e0bda64b5875ddd6791ccb39797d470c3a7d8512912fd876742eb899d46