Skip to content

fix(desktop): discover current Cursor Agent CLI #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p-prash wants to merge 1 commit into from
Closed

fix(desktop): discover current Cursor Agent CLI #7571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions desktop/src-tauri/src/managed_agents/discovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,13 +563,22 @@ pub(crate) fn availability_drift(
/// On Windows also includes `.cmd` and `.bat` variants so npm-generated shims
/// (e.g. `codex-acp.cmd` in `%APPDATA%\npm`) are discoverable.
fn command_basenames(command: &str) -> Vec<String> {
let candidates = vec![executable_basename(command)];
let mut candidates = vec![executable_basename(command)];
// Cursor renamed its native CLI from `cursor-agent` to `agent`. Keep the
// old command as a compatibility alias for persisted harness records and
// older custom configurations while preferring the current binary.
if command.eq_ignore_ascii_case("cursor-agent") {
candidates.push(executable_basename("agent"));
}
#[cfg(windows)]
{
let mut candidates = candidates;
if !command.contains('.') {
candidates.push(format!("{command}.cmd"));
candidates.push(format!("{command}.bat"));
if command.eq_ignore_ascii_case("cursor-agent") {
candidates.push("agent.cmd".to_string());
candidates.push("agent.bat".to_string());
}
}
return candidates;
}
Expand Down
4 changes: 2 additions & 2 deletions desktop/src-tauri/src/managed_agents/discovery/presets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ pub(super) const PRESET_HARNESSES: &[PresetHarness] = &[
PresetHarness {
id: "cursor",
label: "Cursor",
command: "cursor-agent",
command: "agent",
args: &["acp"],
install_instructions_url: "https://cursor.com/downloads",
install_hint: "Buzz talks to Cursor through the cursor-agent CLI's ACP mode.",
install_hint: "Buzz talks to Cursor through the Cursor Agent CLI's ACP mode.",
underlying_cli: None,
underlying_cli_install_hint: None,
underlying_cli_install_instructions_url: None,
Expand Down
22 changes: 22 additions & 0 deletions desktop/src-tauri/src/managed_agents/discovery/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,28 @@ use super::{
};
use crate::managed_agents::AcpAvailabilityStatus;

#[test]
fn cursor_preset_uses_renamed_cli_and_keeps_legacy_alias() {
let candidates = super::command_basenames("cursor-agent");
let cursor = super::preset_harness_definitions()
.into_iter()
.find(|harness| harness.id == "cursor")
.unwrap();

assert_eq!(candidates.first().map(String::as_str), Some("cursor-agent"));
assert!(
candidates.iter().any(|candidate| {
candidate == "agent"
|| candidate == "agent.exe"
|| candidate == "agent.cmd"
|| candidate == "agent.bat"
}),
"Cursor's current agent binary must be discoverable as a compatibility alias"
);
assert_eq!(cursor.command, "agent");
assert_eq!(cursor.args, vec!["acp".to_string()]);
}

#[test]
fn resolves_known_avatar_for_bare_command() {
let avatar_url = managed_agent_avatar_url("goose").expect("goose avatar should resolve");
Expand Down
6 changes: 3 additions & 3 deletions desktop/tests/e2e/harness-catalog-screenshots.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ const CATALOG = [
label: "Cursor",
avatar_url: "",
availability: "available",
command: "cursor-agent",
binary_path: "/usr/local/bin/cursor-agent",
command: "agent",
binary_path: "/usr/local/bin/agent",
default_args: ["acp"],
mcp_command: null,
install_hint:
"Buzz talks to Cursor through the cursor-agent CLI's ACP mode.",
"Buzz talks to Cursor through the Cursor Agent CLI's ACP mode.",
install_instructions_url: "https://cursor.com/downloads",
can_auto_install: false,
underlying_cli_path: null,
Expand Down
6 changes: 3 additions & 3 deletions desktop/tests/e2e/harness-management.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ const CURSOR_AVAILABLE = {
label: "Cursor",
avatar_url: "",
availability: "available",
command: "cursor-agent",
binary_path: "/usr/local/bin/cursor-agent",
command: "agent",
binary_path: "/usr/local/bin/agent",
default_args: [],
mcp_command: null,
install_hint: "Buzz talks to Cursor through the cursor-agent CLI's ACP mode.",
install_hint: "Buzz talks to Cursor through the Cursor Agent CLI's ACP mode.",
install_instructions_url: "https://cursor.com/cli",
can_auto_install: false,
requires_external_cli: true,
Expand Down