fix(ci): pull pinned MinIO images from Quay - #7599
Conversation
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
🔐 Codex Security Review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No actionable findings for head b89c146b1f6f2edfc1d59074392108dfe0006c59 against base 78618804ec86a014524ad7d1fb55928e8f5c3edf. This is a clear source/metadata review, not an approval.
- Contract: restore MinIO pulls while preserving storage, credentials, bucket privacy and startup ordering. Reviewed development Compose, harness Compose, deployment Compose, and all three Helm image consumers. They consistently use the new references without modifying those contracts; bundled Helm MinIO remains opt-in and external S3 is unaffected.
- Image compatibility: both Quay release tags return manifest-list bytes whose SHA-256 matches the pinned digest, with Linux AMD64 and ARM64 entries. Independent review checked release/config identity and existing init/healthcheck command support; I verified the manifest hashes/platforms and exact-release Dockerfiles. Full image references pass through the Helm templates unchanged.
- Validation: exact-head Helm lint/unit/render CI passed, and integration CI passed root-Compose startup and MinIO health checks. The live kind install was skipped; the parent integration workflow was still running at inspection. The PR also reports AMD64/ARM64 object upload/read/delete and bucket-privacy checks, which are author-reported evidence. This automation ran no containers, builds or tests and did not verify image layers, live Kubernetes startup, or existing-volume migration.
* origin/main: feat(buzz-agent): add opt-in workspace-scoped Databricks reuse (#7606) fix(acp): improve hints in pi agent setup guide (#7594) fix(ci): pull pinned MinIO images from Quay (#7599) Configure ACP session scope per agent (#7578) refactor(buzz-acp): point agents at buzz --help instead of a command table (#7586) feat(buzz-cli): render an agent-friendly command tree in --help (#7584) fix(avatars): scale agent squircles from normalized paths (#7307) fix(mobile): bind same-name mentions to exact selected identities (#7385) fix(desktop): isolate quota backoff and reuse channel discovery rosters (#6998) test(desktop): isolate login-shell probe measurements (#7570) feat(git): add default-branch management to relay and CLI (#7562) fix(acp): integrate the Buzz Pi adapter fork (#7552) Signed-off-by: Meli <5aaa86bce934fc3445fc254aab560a40923f10252f92107e665073dede0e04d3@buzz.block.builderlab.xyz> # Conflicts: # Cargo.lock
Docker Hub denies minio/minio and minio/mc pulls, which fails the compose-based jobs on this branch before tests start. Point the dev, harness, deploy compose, and chart refs at quay.io with the same release tags plus multi-arch digests, matching upstream block#7599. Update the ARCHITECTURE.md service table to match. Signed-off-by: cursor-agent <cursor-agent@local> Co-authored-by: only21mil <only21mil@users.noreply.github.com>
## Summary CI is failing in `main` before tests start because Docker Hub denies pulls for `minio/minio` and `minio/mc`. Retrying the failed jobs produced the same errors. Use MinIO’s Quay images in the development, harness, deployment Compose, and Helm configurations. Pin each image to its multi-platform digest and retain the release tags already used by deployment templates. Update the architecture reference to match. ### Related issue No duplicate issue or PR found. Addresses the image-pull failures in [main CI attempt 2](https://github.com/block/buzz/actions/runs/34645306855/attempts/2). ### Testing - Pulled both pinned images for Linux ARM64 and AMD64. - Started an isolated Compose stack derived from the updated MinIO service definitions, once per architecture (AMD64 under local emulation). - Verified the existing health check passed and the bucket initializer exited with code 0. - Uploaded an object with `mc cp`, read it with `mc cat`, compared its content, and deleted it with `mc rm` on both architectures. - Confirmed the initialized bucket was private and removed the temporary stack and volume. Generated with Codex (cherry picked from commit f3940ff) Signed-off-by: Salman Mohammed <smohammed@squareup.com> Co-authored-by: Salman Mohammed <smohammed@squareup.com>
* origin/main: (110 commits) feat(buzz-agent): add opt-in workspace-scoped Databricks reuse (#7606) fix(acp): improve hints in pi agent setup guide (#7594) fix(ci): pull pinned MinIO images from Quay (#7599) Configure ACP session scope per agent (#7578) refactor(buzz-acp): point agents at buzz --help instead of a command table (#7586) feat(buzz-cli): render an agent-friendly command tree in --help (#7584) fix(avatars): scale agent squircles from normalized paths (#7307) fix(mobile): bind same-name mentions to exact selected identities (#7385) fix(desktop): isolate quota backoff and reuse channel discovery rosters (#6998) test(desktop): isolate login-shell probe measurements (#7570) feat(git): add default-branch management to relay and CLI (#7562) fix(acp): integrate the Buzz Pi adapter fork (#7552) fix(markdown): align mention chip wrapping (#7501) fix(relay): reject presence updates when Redis storage fails (#7532) fix(desktop): let inbox title and message author names truncate under narrow panes (#7550) fix(buzz-acp): report missing models without retrying (#7538) fix(desktop): require a Codex adapter with Astra support (#7427) fix(desktop): order unnamed roster members by full canonical npub (#7503) fix(mobile): standardize public-key identity display on npub (#7493) fix(desktop): npub identity controls across profile, agents, and workflows (#7489) ... Signed-off-by: Alessandro Joabar <sandro@squareup.com>
…eway-origin * origin/main: (23 commits) feat(buzz-agent): add opt-in workspace-scoped Databricks reuse (#7606) fix(acp): improve hints in pi agent setup guide (#7594) fix(ci): pull pinned MinIO images from Quay (#7599) Configure ACP session scope per agent (#7578) refactor(buzz-acp): point agents at buzz --help instead of a command table (#7586) feat(buzz-cli): render an agent-friendly command tree in --help (#7584) fix(avatars): scale agent squircles from normalized paths (#7307) fix(mobile): bind same-name mentions to exact selected identities (#7385) fix(desktop): isolate quota backoff and reuse channel discovery rosters (#6998) test(desktop): isolate login-shell probe measurements (#7570) feat(git): add default-branch management to relay and CLI (#7562) fix(acp): integrate the Buzz Pi adapter fork (#7552) fix(markdown): align mention chip wrapping (#7501) fix(relay): reject presence updates when Redis storage fails (#7532) fix(desktop): let inbox title and message author names truncate under narrow panes (#7550) fix(buzz-acp): report missing models without retrying (#7538) fix(desktop): require a Codex adapter with Astra support (#7427) fix(desktop): order unnamed roster members by full canonical npub (#7503) fix(mobile): standardize public-key identity display on npub (#7493) fix(desktop): npub identity controls across profile, agents, and workflows (#7489) ... Signed-off-by: Tom Brow <tomb@block.xyz>
## Summary CI is failing in `main` before tests start because Docker Hub denies pulls for `minio/minio` and `minio/mc`. Retrying the failed jobs produced the same errors. Use MinIO’s Quay images in the development, harness, deployment Compose, and Helm configurations. Pin each image to its multi-platform digest and retain the release tags already used by deployment templates. Update the architecture reference to match. ### Related issue No duplicate issue or PR found. Addresses the image-pull failures in [main CI attempt 2](https://github.com/block/buzz/actions/runs/34645306855/attempts/2). ### Testing - Pulled both pinned images for Linux ARM64 and AMD64. - Started an isolated Compose stack derived from the updated MinIO service definitions, once per architecture (AMD64 under local emulation). - Verified the existing health check passed and the bucket initializer exited with code 0. - Uploaded an object with `mc cp`, read it with `mc cat`, compared its content, and deleted it with `mc rm` on both architectures. - Confirmed the initialized bucket was private and removed the temporary stack and volume. Generated with Codex Signed-off-by: Salman Mohammed <smohammed@squareup.com> (cherry picked from commit f3940ff) Signed-off-by: Cvv <varun.cumbamangalam@oralens.com>
Summary
CI is failing in
mainbefore tests start because Docker Hub denies pulls forminio/minioandminio/mc. Retrying the failed jobs produced the same errors.Use MinIO’s Quay images in the development, harness, deployment Compose, and Helm configurations. Pin each image to its multi-platform digest and retain the release tags already used by deployment templates. Update the architecture reference to match.
Related issue
No duplicate issue or PR found. Addresses the image-pull failures in main CI attempt 2.
Testing
mc cp, read it withmc cat, compared its content, and deleted it withmc rmon both architectures.Generated with Codex