Conversation
Signed-off-by: Ravneet Arora <rarora@squareup.com>
Signed-off-by: Ravneet Arora <rarora@squareup.com>
🔐 Codex Security Review
|
Signed-off-by: Ravneet Arora <rarora@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buzz's Helm chart currently creates only a Kubernetes Deployment. This adds an optional Argo Rollout so operators can introduce manual canary updates without replacing the existing pod configuration.
rollout.enabled: falseby default. Existing Deployment and autoscaling behavior remain available.workloadRefand creates its own pods.rollout.deploymentReplicasandrollout.replicas. Enabling the flag alone fails instead of scaling down an existing Deployment.workloadRef.scaleDown: never; values control the handover counts. Reject counts below the fleet target or above one extra requested pod.The initial Rollout revision skips canary steps. Operators must apply each handover step separately and verify health before draining another pod. Replica validation cannot prove healthy capacity.
This prepares chart version
0.1.9. It does not install the Argo controller, enable Rollouts in an environment, or add shadow analyses and automatic recovery decisions. Those remain separate changes.Related issue
None found for chart opt-in support. Related observability work: #7546.
Testing
213092074for single-replica, two-replica, HPA, and custom-name configurations. Output was identical with chart metadata held at version0.1.8.values.yamlto exercise missingrolloutsettings, as with reused release values. Fixed-replica and HPA output remained identical.kubeconform.just ciwas attempted but stopped at Rust linking because the local Xcode license is unaccepted.Generated with Codex