Uh oh!
There was an error while loading. Please reload this page.
#38 - composer binary improvements - #40
Merged
Merged
Conversation
krzysztofrewak
requested changes
Nov 8, 2022
krzysztofrewak
left a comment
Member
There was a problem hiding this comment.
Have you checked how smaller is this new container sizewise?
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Krzysztof Rewak <krzysztof.rewak@blumilk.pl>
MemberAuthor
@krzysztofrewak To sum up, there is no big difference (in this case), but Dockerfile is more clear when composer bin is copying from the image. |
krzysztofrewak
approved these changes
Nov 8, 2022
kamilpiech97
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use composer binary from docker image instead of curl installation.
Should close#38