Skip to content

Fix Miri error with -Zmiri-tag-raw-pointers #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluss merged 2 commits into from
May 1, 2022
Merged

Fix Miri error with -Zmiri-tag-raw-pointers #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220d35a
Fix Miri error with -Zmiri-tag-raw-pointers
jturner314 Dec 23, 2021
049680b
Add more checks to MIRIFLAGS for CI
jturner314 Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ci/miri.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ rustup default "$MIRI_NIGHTLY"
rustup component add miri
cargo miri setup

# disable isolation for num_cpus::get_physical
MIRIFLAGS=-Zmiri-disable-isolation \
# Disable isolation for num_cpus::get_physical.
# Also add flags for additional checks.
MIRIFLAGS="-Zmiri-disable-isolation -Zmiri-tag-raw-pointers -Zmiri-check-number-validity" \
MMTEST_FAST_TEST=1 \
cargo miri test "$@"
4 changes: 2 additions & 2 deletions src/gemm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,8 @@ unsafe fn gemm_packed<K>(nc: usize, kc: usize, mc: usize,
// NOTE: For the rust kernels, it performs better to simply
// always use the masked kernel function!
if K::always_masked() || nr_ < nr || mr_ < mr {
masked_kernel::<_, K>(kc, alpha, &*app.ptr(), &*bpp.ptr(),
beta, &mut *c.ptr(), rsc, csc,
masked_kernel::<_, K>(kc, alpha, app.ptr(), bpp.ptr(),
beta, c.ptr(), rsc, csc,
mr_, nr_, mask_buf);
continue;
} else {
Expand Down