Fixed setup installer and pypi packaging - #4
Conversation
bmx0r
commented
Aug 29, 2019
hi, pipy change the default readme to md... that is why i had to change it... I also add you as contributor, I enforce the review on PR thought Thanks a lot :) |
Installing via pip was not working due to the README.md being missing from the MANIFEST.in file, and resulting in an install failure due to FileNotFoundError exception.
I've added a robust check that will fall back to the .rst file since it was present, in case the markdown file is missing, as well as added an
include *.mdto the manifest so that README.md is included. Feel free to modify this according to your preferred packaging.One caveat is that, whichever readme.md/rst if going to be the de-facto should take precedence in setup.py.
I am at a loss as to why Travis builds fail on setup.py. I've tested it on my local system and in a venv without any issues.
Also... side note... I don't know if issues were disabled intentionally, but that is going to make maintaining this project pretty difficult if people can't report bugs. If you guys aren't able to address issues regularly because you need help maintaining the project, I'm willing to assist. I use this library very regularly, so I'd be willing to help contribute. ✌️