Add adaptive_diag_scale setting binding - #225
Open
bodono wants to merge 1 commit into
Open
Conversation
bodonoforce-pushed
the
feature/adaptive-diag-scale-binding
branch
2 times, most recently
from
August 9, 2026 13:38
81cd977 to
27afc4aCompareInteger level 0 (off, default) / 1 (rows) / 2 (rows + columns); Python bools accepted as 0/1 since bool subclasses int. Mirrors the C-side validation. scs_source pin to be bumped to the upstream commit once the corresponding scs PR merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bodonoforce-pushed
the
feature/adaptive-diag-scale-binding
branch
from
August 9, 2026 13:56
27afc4a to
5a0bd1bCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Binding for the new
adaptive_diag_scalesolver setting (cvxgrp/scs#401): integer level 0 (off, default) / 1 (rows) / 2 (rows + columns), parsed as an int in the argparse string so Python bools are also accepted (bool subclasses int). Python-side validation mirrors the C-side check with a clear error message.Notes
scs_sourcesubmodule is pinned tocvxgrp/scs@pin/scs-python-adaptive-diag-scale, a merge of the #401 branch withexpose-aa-trust-factor— needed because this repo's test suite expects the +inf eps_*/time_limit sentinel behavior from that in-flight branch, which current scs master rejects (any pin bump to scs master would hit the same failures independently of this PR). Re-pin to the upstream merge commit once both scs branches land.🤖 Generated with Claude Code