Fix duplicated emission and implement graceful shutdown - #1
Closed
mpyw wants to merge 4 commits into
Closed
Conversation
| $scope = $this; | ||
| $connection->on('connection', function ($dataConn) use ($scope) { | ||
| $scope->emit('connection', array($dataConn)); | ||
| }); |
Author
There was a problem hiding this comment.
It seems to be duplicated to
socket/src/SecureConnection.php
Line 27 in feeaed4
if (! $this->isSecure) {
$enabled = stream_socket_enable_crypto($stream, true, $this->protocolNumber);
if ($enabled === false) {
$this
->err('Failed to complete a secure handshake with the client.')
->end()
;
return;
} elseif ($enabled === 0) {
return;
}
$this->isSecure = true;
$this->emit('connection', array($this));
}Actually I verified responses are duplicated in my product mpyw/php-hyper-builtin-server and my commit fixes the issue.
| if (false === stream_socket_enable_crypto($stream, false)) { | ||
| $scope->err('Failed to gracefully shutdown a secure connection.'); | ||
| } | ||
| }); |
Author
There was a problem hiding this comment.
This is required for graceful shutdown
boite
commented
Aug 31, 2016
Owner
Thank you @mpyw. I will review these changes as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using your great commit in mpyw/php-hyper-builtin-server, thank you!!
However, there are some bugs to be fixed.