fix(@clack/prompts): handle spinner.stop call when spinner.start was not called

[Minishlink]

Basic reproduction would be

constspin=spinner();try{awaitdoSomethingWithAnotherSpinnerInsideAndThrows();spin.start('loading do');awaitdoSomething()spin.stop('success!')}catch(error){spin.stop('error!',2)handleError(error)}

[changeset-bot]

⚠️ No Changeset found

Latest commit: b78366c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[DogPawHat]

Wouldn't it be better if it threw an error instead if stop was called before start?

if (!isSpinnerActive) {
throw new Error('You can not stop the spinner if it is not active');
}

[Minishlink]

I'd rather make .stop return early if !isSpinnerActive but I'm ok with this if you can access isSpinnerActive publicly

[43081j]

i think we should return early like you say

so keep unblock as it is (because if we reach it, it must've been initialised), but change stop to return early:

if(!isSpinnerActive){return;}

[43081j]

looks like this was fixed in 0b852e1