Uh oh!
There was an error while loading. Please reload this page.
feat: standard schema for validation - #543
Conversation
🦋 Changeset detectedLatest commit: f1419b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
ghostdevv
left a comment
There was a problem hiding this comment.
the jsdoc comments above the validate options would need updating, as well as the docs https://github.com/bombshell-dev/docs/
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
natemoo-re
left a comment
There was a problem hiding this comment.
Code looks great, changeset is perfect, just minor feedback on the example!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I also want to note that the PR does not support schema transforms (they will run but not be used). That would require more changes to represent input and output in types. Out of scope of this PR but if you're interested let me know! |
florian-lefebvre
commented
May 20, 2026
@ghostdevv docs PR is available at bombshell-dev/docs#42 |
ghostdevv
commented
May 20, 2026
Also, this would be breaking right? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
florian-lefebvre
commented
May 20, 2026
@43081j yeah I was also hesitating. I inlined it, the spec says it's absolutely fine |
florian-lefebvre
commented
May 20, 2026
@ghostdevv by "this", are you referring to input/output/transforms or this PR? |
ghostdevv
commented
May 20, 2026
Yea, as this PR changes the behavior of the |
I'm not sure it's fully breaking. No change as a user but it's true that if you are dealing with lower level APIs like in the date prompt, then it requires changes. So maybe it's a major for core and a minor for prompts |
ghostdevv
commented
May 20, 2026
Ah, I'm so sorry but I missed the fact that the old behavior is still available 🤦♀️ |
43081j
commented
May 21, 2026
technically, we can strip the standard schema types down to only the parts we use too. but i'm happy either way. inlining it is better than pulling a dependency still |
florian-lefebvre
commented
May 21, 2026
I just checked and very little can be stripped, only |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
dreyfus92
left a comment
There was a problem hiding this comment.
thank you @florian-lefebvre 💜
What does this PR do?
Allows using Standard Schema compatible libraries for
validate(). Discussed on Discord.Docs PR: bombshell-dev/docs#42
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure