fix ucontext for MacOS - #213

Merged
olk merged 1 commit into
boostorg:developfrom
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged

fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom
eduardvoronkin:fix_ucontext_macos

Conversation

@eduardvoronkin

@eduardvoronkineduardvoronkin commented Dec 16, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h

#184

@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin mentioned this pull request Dec 16, 2022
Closed
@elfprince13

elfprince13 commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

So sounds like this likely doesn't solve #198?

@eduardvoronkin

eduardvoronkin commented Dec 16, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

So sounds like this likely doesn't solve #198?

This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition

_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};

if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).

One of examples of such bad include sequence:

In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.

To summarize:

  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)

@rwsfisker

rwsfisker commented Dec 16, 2022

Copy link
Copy Markdown

So sounds like this likely doesn't solve #198?

It does:


# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker

rwsfisker commented Dec 16, 2022

Copy link
Copy Markdown

Verified Mac OSX 13, x86_64

@olk
olk merged commit 984f789 into boostorg:developDec 17, 2022
@olk

olk commented Dec 17, 2022

Copy link
Copy Markdown
Member

ty

@olkolk mentioned this pull request Dec 17, 2022
Closed
@francoiskfrancoisk mentioned this pull request Sep 6, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix ucontext for MacOS - #213
Merged
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Dec 17, 2022
Merged
fix ucontext for MacOS#213
olk merged 1 commit into
boostorg:developfrom 
eduardvoronkin:fix_ucontext_macos
Conversation
@eduardvoronkin
@eduardvoronkineduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
  1. MacOS version of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
  2. define _XOPEN_SOURCE before inclusion of predef.h
#184
@eduardvoronkin
fix ucontext for MacOS:
cc106be
1. MacOS versions of ::makecontext (tested on m1 Mac Ventura 13.0.1) is able to pass only 4-byte parameters to context function
2. define _XOPEN_SOURCE before inclusion of predef.h
@eduardvoronkineduardvoronkin
mentioned this pull request
Dec 16, 2022

Closed

@elfprince13
elfprince13
commented
Dec 16, 2022

Copy link


Copy Markdown

Contributor
So sounds like this likely doesn't solve #198?
@eduardvoronkin
eduardvoronkin
commented
Dec 16, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So sounds like this likely doesn't solve #198?
This should solve this. At least, we got boost asio/context working with address sanitizer. Another tricky thing is that you need to keep track of is the _XOPEN_SOURCE macro. I fixed this issue in context, but the same issue remains in boost.asio and actually this is MacOS issue. There are some "bad" headers that lead to inclusion of /sys/_types/_ucontext.h (the file with definition of ucontext struct) WITHOUT this macro. So, as you see from definition
_STRUCT_UCONTEXT
{
int uc_onstack;
__darwin_sigset_t uc_sigmask; /* signal mask used by this context */
_STRUCT_SIGALTSTACK uc_stack; /* stack used by this context */
_STRUCT_UCONTEXT *uc_link; /* pointer to resuming context */__darwin_size_t uc_mcsize; /* size of the machine context passed in */
_STRUCT_MCONTEXT *uc_mcontext; /* pointer to machine specific context */
#ifdef _XOPEN_SOURCE
_STRUCT_MCONTEXT __mcontext_data;
#endif/* _XOPEN_SOURCE */
};
if we include this WITHOUT _XOPEN_SOURCE, the struct will lack one of its field. But then, lately, we include sys/ucontext.h, which expects this macro to be defined, and it's actually defined, but it's too late, bc we already have "bad" version of the structure in current translation unit (second inclusion from sys/ucontext.h DOES NOT happen bc of include guard in /sys/_types/_ucontext.h). And then some weird issues happening (getcontext does memory overrun).
One of examples of such bad include sequence:
In file included from /myproj/boost-src/boost/asio/append.hpp:24:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/tuple:154:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/__functional_base:22:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/exception:83:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/cstdlib:85:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/c++/v1/stdlib.h:93:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/stdlib.h:66:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/wait.h:109:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk/usr/include/sys/signal.h:151:

and then signal.h on line 151 includes #include <sys/_types/_ucontext.h>.
To summarize:
  1. Need fix for entry_func, bc makecontext does not work properly (at lease, on my MacOS EVEN with _XOPEN_SOURCE).
  2. Need to make sure that _XOPEN_SOURCE is defined for sources that are using boost.context directly or indirectly. If you building with CMake, just add target_compile_definitions(boost_context PUBLIC _XOPEN_SOURCE)
@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

So sounds like this likely doesn't solve #198?
It does:

# clone boost, build boost_context
git clone --recurse-submodules -j8 https://github.com/boostorg/boost.git
cd boost
boost_root=`pwd`
./bootstrap.sh --with-libraries=context
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# clone / build crash reproducer
git clone --recursive --branch crash-reproducer-2022.05.05 https://github.com/Geopipe/Cxx-Bidirectional-Coroutines.git
mkdir Cxx-Bidirectional-Coroutines/build
cd Cxx-Bidirectional-Coroutines/build
cmake \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize=undefined -fsanitize-recover=all -DBOOST_USE_ASAN -DBOOST_USE_UCONTEXT" \
-DCMAKE_PREFIX_PATH=${boost_root}/stage/lib/cmake/Boost-1.82.0/ \
-S.. -B.
cmake --build .
# it crashes
./example/testcoro # crashes
# apply the patch / rebuild
test_root=`pwd`
cd ${boost_root}/libs/context
curl https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc.diff | git apply -
cd ${boost_root}
./b2 -a cxxflags='-std=c++17' context-impl=ucontext stage
# build it again, it works!
cd ${test_root}
cmake --build .
% ./example/testcoro
Fibs
0
1
1
2
3
5
8
13
21
34
RBC
1
1
1
2
3
3
4
Noise
Moo/0
Moo/1
Moo/2
Moo/3
Moo/4
Moo/5
Moo/6

@rwsfisker
rwsfisker
commented
Dec 16, 2022

Copy link


Copy Markdown

Verified Mac OSX 13, x86_64
@olk
olk
merged commit 984f789
into
boostorg:developDec 17, 2022
@olk
olk
commented
Dec 17, 2022

Copy link


Copy Markdown

Member
ty
@olkolk
mentioned this pull request
Dec 17, 2022

Closed

@francoiskfrancoisk
mentioned this pull request
Sep 6, 2023

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eduardvoronkin@elfprince13@rwsfisker@olk