Uh oh!
There was an error while loading. Please reload this page.
Add pmr image typedefs - #529
Merged
Merged
Conversation
sdebionneforce-pushed
the
add-pmr-image
branch
2 times, most recently
from
May 4, 2022 10:08
56f968d to
979b7f1CompareCodecov Report
@@ Coverage Diff @@## develop #529 +/- ##
========================================
Coverage 80.84% 80.84% ========================================
Files 116 116 Lines 5121 5127 +6 ========================================
+ Hits 4140 4145 +5 - Misses 981 982 +1 |
sdebionne
marked this pull request as ready for review
May 4, 2022 10:38
sdebionne
commented
May 4, 2022
ContributorAuthor
I would be happy to remove the |
sdebionne
commented
May 20, 2022
Uh oh!
There was an error while loading. Please reload this page.
mloskot
approved these changes
May 20, 2022
mloskot
commented
Jun 26, 2022
Member
I have updated this PR with latest |
Member
The GCC 11 drops the warning: and C++14 compilation mode is failing, obviously. Some |
ContributorAuthor
Thanks for looking into the issue, |
mloskot added a commit
that referenced
this pull request
Jun 29, 2022
* develop: test: Add more basic cases for image class (#423) test: Add virtual_2d_locator fixture; is_2d_traversable test case test: Check more properties of indexed_image_view from extension/toolbox test: Add basic is_1d_traversable cases for image_view chore: Update CMakeSettings.json sample [ci skip] chore: Update CMake to use latest cmake-conan/0.18.1 [ci skip] Add pmr image typedefs (#529) test: Add test cases for image with empty dimensions (#702) test: Case test_constructor_from_view was not called fix: Memory leak in image class for empty dimensions (#649) docs: Bump C++11 to C++14 as current required (#700) ci: Remove C++11 build jobs after C++14 switch (#698) build: Fix CMake source file extensions must be explicit refactor: Switch to trailing return types (#599) build: Bump Boost required by CMake from 1.72 to 1.80 build: Update CMAKE_CXX_STANDARD from 11 to 14
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when building with C++17 standard, adds pmr (polymorphic memroy resource) image typedefs (e.g.
gil::pmr::gray8_image_t = using image<gray8_pixel_t, false, std::pmr::polymorphic_allocator<unsigned char>).Fixes#528.
Tasklist
<memory_resource>and typedefs