Skip to content

Fix missing Boost::stl_interfaces dependency in CMakeLists.txt - #802

Merged
sdebionne merged 1 commit into
boostorg:developfrom
sdebionne:fix-cmake-missing-stl-interface
Sep 2, 2026
Merged

Fix missing Boost::stl_interfaces dependency in CMakeLists.txt#802
sdebionne merged 1 commit into
boostorg:developfrom
sdebionne:fix-cmake-missing-stl-interface

Conversation

@sdebionne

Copy link
Copy Markdown
Contributor

Description

An issue with CMake introduced with the switch to Boost.STLInterfaces:

boost/gil/pixel_iterator_adaptor.hpp includes boost/stl_interfaces/iterator_interface.hpp, but the boost_gil target's link libraries never declared Boost::stl_interfaces. Building gil via a minimal CMake superbuild (BOOST_INCLUDE_LIBRARIES=gil) therefore fails to pull in stl_interfaces at all, causing a missing-header error.

This does not show up with the CI since the tests are build with Boost.Build.

Tasklist

  • Ensure all CI builds pass
  • Review and approve

boost/gil/pixel_iterator_adaptor.hpp includes
boost/stl_interfaces/iterator_interface.hpp, but the boost_gil target's
link libraries never declared Boost::stl_interfaces. Building gil via a
minimal CMake superbuild (BOOST_INCLUDE_LIBRARIES=gil) therefore fails
to pull in stl_interfaces at all, causing a missing-header error.
@sdebionnesdebionne added this to the Boost 1.93 milestone Sep 2, 2026
@sdebionnesdebionne self-assigned this Sep 2, 2026
@sdebionnesdebionne added the cat/bug But reports and bug fixes label Sep 2, 2026
@sdebionne
sdebionne marked this pull request as ready for review September 2, 2026 19:46
@codecov

codecovBot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.05%. Comparing base (4d97acb) to head (646df18).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@ Coverage Diff @@## develop #802 +/- ##
===========================================
- Coverage 82.05% 82.05% -0.01% 
===========================================
Files 117 117 Lines 5383 5382 -1 ===========================================
- Hits 4417 4416 -1 
Misses 966 966 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdebionne
sdebionne merged commit 0405ae4 into boostorg:developSep 2, 2026
31 checks passed
@sdebionne
sdebionne deleted the fix-cmake-missing-stl-interface branch September 2, 2026 20:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat/bugBut reports and bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sdebionne@mloskot