Inheriting std::iterator is deprecated in C++17

[DanielaE]

Boost's iterator.hpp is deprecated, too. Therefore get rid of all of that and replace inheritance by lifting std::iterator's members into the derived class.

Signed-off-by: Daniela Engert dani@ngrt.de

[davydden]

this should also fix https://svn.boost.org/trac10/ticket/13505

@ericniebler@Belcourt ping.

[davydden]

@DanielaE please rebase and see #104 (comment)

[DanielaE]

Done 😄

[morinmorin]

typedef ArrayBinaryTreeNode::difference_type difference_type;
typedef ArrayBinaryTreeNode* pointer;

would be more readable?

[anadon]

I'm helping out with the PR backlog. Looks like you have a code change. I need to look into how this will affect backwards compatibility with C++ standards. This is to let you know and help me prioritize PR's.

[DanielaE]

It doesn't change it in any respect.

[anadon]

It uses tags/traits, which are not something necessarily safe for C++03. I'm going to do some additional testing to satisfy myself that this is either a safe change, or going to be pushed off.

[DanielaE]

Well, no - it does not.

[anadon]

OK, I'm mixing up 2a/2z stuff with 03.
Suggested by http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2003/n1424.htm
This will be put into the second batch of merges.

[DanielaE]

Graph is one of the 5 last users of boost::iterator, the empty shell around std::iterator which itself is deprecated in C++17 http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#2.1 (with all it's consequences) and about to be removed from the language.

[jzmaddock]

Ooops, that reference was to the wrong PR :(

[anadon]

@jzmaddock Can you trigger a build on this?

[jzmaddock]

Closing and re-opening to trigger a CI build.

[jzmaddock]

Looks good to me, but I'll wait for Appveyor to catch up before merging...

[anadon]

@jzmaddock All clear.