Uh oh!
There was an error while loading. Please reload this page.
Fix [un]directed_graph::swap and add tests - #5
Merged
Conversation
BenPope
commented
May 14, 2014
ContributorAuthor
Some other points you might like to comment on:
Should I look into reimplementing adjacency_list::swap to be cheap and correct, and then reimplement copy and assignment in the idiomatic way? I'm also considering free function swap, but that didn't seem to work when I gave it a quick try, perhaps because it should exist in the boost namespace (for ADL) and doesn't get picked up over boost/utility/swap, or I may have messed up the implementation. |
Belcourt added a commit
that referenced
this pull request
May 14, 2014
Fix [un]directed_graph::swap and add tests Nice job, thanks! I'll have to look at your other points a bit more carefully before responding.
BenPope
commented
May 14, 2014
ContributorAuthor
That was quick, nice one! |
jzmaddock pushed a commit
that referenced
this pull request
Oct 12, 2018
Getting together PR's for first batch of merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.