Skip to content

fix: astar_search_test.cpp did not test correctness - #558

Open
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/astar-assert
Open

fix: astar_search_test.cpp did not test correctness#558
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/astar-assert

Conversation

@Becheler

Copy link
Copy Markdown
Collaborator

The test was simply printing.

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

  • removed dead code and uselss printing
  • introduced BOOST_TEST
  • modernized type aliases and constexpr

Motivation

Tests should not rely on printing.

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@BechelerBecheler self-assigned this Aug 10, 2026
@BechelerBecheler added technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. test Adding, fixing or modernizing unit tests labels Aug 10, 2026
@github-actions

github-actionsBot commented Aug 10, 2026

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 31398882275 vs develop run 31385980713 (43030dbcb3).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 68 → 68 (0)

@codecov

codecovBot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.82%. Comparing base (bc05361) to head (43030db).
⚠️ Report is 1 commits behind head on develop.

Files with missing linesPatch %Lines
test/astar_search_test.cpp97.36%0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## develop #558 +/- ##
===========================================
+ Coverage 88.22% 92.82% +4.60% 
===========================================
Files 392 392 Lines 27412 28176 +764 Branches 7997 7990 -7 ===========================================
+ Hits 24183 26155 +1972 - Misses 1881 1916 +35 + Partials 1348 105 -1243 
Files with missing linesCoverage Δ
test/astar_search_test.cpp98.79% <97.36%> (+4.15%)⬆️

... and 288 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e818d4...43030db. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 31398882144 vs develop run 31385980794 (43030dbcb3).

JobBaselineAfterDelta
macos (clang, 14)681680-1
macos (clang, 17)6416410
macos (clang, 20)6416410
ubuntu (clang-19, 14)681680-1
ubuntu (clang-19, 17)6416410
ubuntu (clang-19, 20)6416410
ubuntu (clang-19, 23)6416410
ubuntu (gcc-14, 14)8278270
ubuntu (gcc-14, 17)9499490
ubuntu (gcc-14, 20)9499490
ubuntu (gcc-14, 23)9499490
windows_msvc_14_3 (msvc-14.3)962959-3

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debtCode that works but needs refactoring, cleanup, or modernization. Not user-facing.testAdding, fixing or modernizing unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Becheler