Uh oh!
There was an error while loading. Please reload this page.
Convert get/set/size to PEP-384 style - #324
Conversation
knoepfel
commented
Oct 21, 2020
@jcpunk, do you have reason to suspect the output of |
I'm really unsure what the changes from |
stefanseefeld
commented
Jan 6, 2021
I'm not entirely sure I understand the purpose of this PR. As far as I can see, all it does is to replace non-checking functions by their checking counter parts, thereby making the code overall slower. (Example: |
jcpunk
commented
Jan 7, 2021
As I understand it, this PR (switching to the checking versions) is a pre-req for the PEP-384 |
Ultimately, for PEP-384 (CPython 3.2+) someone who understands the output needs to run
abitype.py[1] againstsrc/object/enum.cppandsrc/object/class.cpp. The slot/spec layouts[2] generated by that code are pretty close to right, but need someone more fluent in this than I....This PR gets the other helpers in place for staying to the stricter ABI.
[1]
https://github.com/python/cpython/blob/master/Tools/scripts/abitype.py
[2]
https://pythoncapi.readthedocs.io/type_object.html#pytype-fromspec