Skip to content

Fix xoshiro constructors using seed seq incorrectly - #148

Merged
mborland merged 3 commits into
developfrom
seedseq
Nov 12, 2025
Merged

Fix xoshiro constructors using seed seq incorrectly#148
mborland merged 3 commits into
developfrom
seedseq

Conversation

@mborland

Copy link
Copy Markdown
Member

Closes: #147

@codecov

codecovBot commented Nov 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.79%. Comparing base (49d131b) to head (c81bc32).
⚠️ Report is 4 commits behind head on develop.

Files with missing linesPatch %Lines
test/github_issue_147.cpp94.73%1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## develop #148 +/- ##
===========================================
- Coverage 95.79% 95.79% -0.01% 
===========================================
Files 115 116 +1 Lines 7640 7659 +19 ===========================================
+ Hits 7319 7337 +18 - Misses 321 322 +1 
Files with missing linesCoverage Δ
include/boost/random/detail/xoshiro_base.hpp100.00% <100.00%> (ø)
test/github_issue_147.cpp94.73% <94.73%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d131b...c81bc32. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland
mborland merged commit 525a07c into developNov 12, 2025
39 of 40 checks passed
@mborland
mborland deleted the seedseq branch November 12, 2025 10:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

64-bit xoshiro generators: all lanes collapse to identical values when seeded via SeedSequence

1 participant

@mborland