Uh oh!
There was an error while loading. Please reload this page.
Fixed unused parameters warnings - #25
Closed
Kojoley wants to merge 1 commit into
Closed
Conversation
Romain-Geissler-1A
commented
Jun 18, 2017
Contributor
Ping. |
jeking3
commented
Oct 8, 2017
Contributor
@swatanabe I made the same changes locally to resolve these warnings; however I didn't comment out the variable name, I just removed the variable name. Easy fix for a couple of warnings... |
Romain-Geissler
commented
Nov 5, 2017
Ping @swatanabe |
Kojoley
commented
Nov 20, 2017
ContributorAuthor
It looks like this will never be merged. |
jeking3
commented
Nov 21, 2017
Contributor
@Kojoley We're in the middle of the boost 1.67 release cycle so I wouldn't expect anything to be merged right now. |
Kojoley
commented
Dec 26, 2017
ContributorAuthor
@swatanabe If the reason of not merging this is because you prefer not commenting argument names but removing them just say me and I will do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes following warnings: