Skip to content

Fixed unused parameters warnings - #25

Closed
Kojoley wants to merge 1 commit into
boostorg:developfrom
Kojoley:fix-unused-parameter-warnings
Closed

Fixed unused parameters warnings#25
Kojoley wants to merge 1 commit into
boostorg:developfrom
Kojoley:fix-unused-parameter-warnings

Conversation

@Kojoley

Copy link
Copy Markdown
Contributor

Fixes following warnings:

In file included from ../../../boost/random.hpp:63:
../../../boost/random/discrete_distribution.hpp:95:60: warning: unused parameter 'average' [-Wunused-parameter]
static WeightType normalize(WeightType val, WeightType average)
^
../../../boost/random/discrete_distribution.hpp:186:66: warning: unused parameter 'weights' [-Wunused-parameter]
static WeightType try_get_sum(const std::vector<WeightType>& weights)
^

@Romain-Geissler-1A

Copy link
Copy Markdown
Contributor

Ping.

@jeking3

Copy link
Copy Markdown
Contributor

@swatanabe I made the same changes locally to resolve these warnings; however I didn't comment out the variable name, I just removed the variable name. Easy fix for a couple of warnings...

@Romain-Geissler

Copy link
Copy Markdown

Ping @swatanabe

@Kojoley

Copy link
Copy Markdown
ContributorAuthor

It looks like this will never be merged.

@jeking3

Copy link
Copy Markdown
Contributor

@Kojoley We're in the middle of the boost 1.67 release cycle so I wouldn't expect anything to be merged right now.

@jeking3jeking3 mentioned this pull request Dec 7, 2017
@Kojoley

Copy link
Copy Markdown
ContributorAuthor

@swatanabe If the reason of not merging this is because you prefer not commenting argument names but removing them just say me and I will do it.

@Kojoley
Kojoley deleted the fix-unused-parameter-warnings branch January 3, 2018 16:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Kojoley@Romain-Geissler-1A@jeking3@Romain-Geissler