std::allocator deprecation warnings in MSVC for Boost 1.68

[rcdailey]

Using MSVC 15.8, I get the following warning using boost regex:

2>e:\code\frontend2\source\core\thirdparty\boost\include\boost\regex\v4\match_results.hpp(60): warning C4996: 'std::allocator<_Ty>::const_reference': warning STL4010: Various members of std::allocator are deprecated in C++17. Use std::allocator_traits instead of accessing these members directly. You can define _SILENCE_CXX17_OLD_ALLOCATOR_MEMBERS_DEPRECATION_WARNING or _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to acknowledge that you have received this warning.
2> with
2> [
2> _Ty=boost::sub_match<const char *>
2> ] (compiling source file E:\code\frontend2\source\Core\MsrInterface\Source\Msr\Parsing\MagstripeParser.cpp)

I have C++17 enabled. Are these supposed to be fixed in v1.68? Or am I missing something? I can disable the warnings but I'd rather have some proper fixes in Boost.

[jzmaddock]

The patches are in develop, but apparently didn't get merged to master. My bad. Will take care of it fr the next release.

[tobias-loew]

Just a remark.
While removing std::iterator from boost/ublas I stumbled over the following issue:
Removing std::iterator may lead to compilation errors since the derived iterator no longer has an "std" base class, thus ADL won't search the std-namespace for unqualified calls.
I searched the stl for empty classes to put as base and the best types I could find are

• std::monospace : empty type, in < variant >
• std::pair<> : not completely empty, in < tuple >

I couldn't find any class designed as the "hoist into the std-namespace" class.

[jeking3]

@jzmaddock was the fix for this merged into master? If so the issue can be resolved.

[jzmaddock]

Yes merged now.