Add support for client binary on upgrade

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM

[nathanleclaire]

Went ahead and implemented this, looking for feedback, how do those file permissions look to you?

ping @SvenDowideit@tianon

[SvenDowideit]

mmm, a couple of things to consider
It'd be nice to only download if the version is different from the one you have.

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

[nathanleclaire]

It'd be nice to only download if the version is different from the one you have.

Agreed, however I'm not sure what the best way to test this would be. Perhaps with the Github API?

On Linux, this is dangerous - I install my docker using the debs - so there it should probably (also?) be optional

Were you thinking this would be optional as a flag, or something that should prompt the user?

[SvenDowideit]

yup, same GH api request as we make to get the iso version number (and we can amend that one to ask the VM what its version is too..)
I'd make it option based on a flag for now :)

[nathanleclaire]

OK, I have added the requested changes:

• only download client binary if user's version lags behind latest (non-RC) tag
• skip client binary upgrade on Linux unless user manually sets --clobber flag

PTAL @SvenDowideit and @tianon 👍

[SvenDowideit]

Capitalise Docker or you'll make James cry.

[nathanleclaire]

;_;

[SvenDowideit]

neat - do you want to do the same for the boot2docker binary? >:}

[SvenDowideit]

Docker, and go on, tell them the version they have

[SvenDowideit]

this would close boot2docker/osx-installer#63

[nathanleclaire]

neat - do you want to do the same for the boot2docker binary? >:}

Yes - perhaps in a separate PR - this would over-write the existing (running) executable with the latest release if it is behind? And it would continue to be part of upgrade command, correct?

[nathanleclaire]

OK @SvenDowideit I have implemented the additional feedback! Let me know if I missed anything. One thing I had thought of is - should we move existing docker binary to docker.bak or something instead of just steamrolling over it if there is a later version?

[tianon]

What's this blank line here for?

[nathanleclaire]

It's an artifact from vim-go (run goimports on save hook).

[SvenDowideit]

@nathanleclaire darn - i presume this got lost in the busyness?

[nathanleclaire]

Yes - finishing it is relatively low hanging fruit but it's too late for this release I'm afraid :( (well, unless the b2d release goes later than the docker 1.3 release)

[nathanleclaire]

Implemented some new stuff (boot2docker-cli binary upgrade) and code review feedback. @SvenDowideit when you get back from vacation and @tianon PTAL

[tianon]

Why the random blank line here? 😄

[nathanleclaire]

goimports as an editor hook >_>

[tianon]

But this doesn't make sense as a goimports change. It's not "remote stuff" being pushed below, it's just other random stdlib imports.

[nathanleclaire]

Must've accidentally added it - I'll fix

[tianon]

Very wishful thinking, and will likely be very wrong (especially since it doesn't even account for GOARM, let alone the actual ARM version of the current system). Please remove and add a default: case that returns an error like was mentioned above. 😉

[tianon]

As a side note, this is where using uname -m as a URL component completely breaks down. For example, on my Pogoplug, I get armv5tel, but armv5el is also very much a thing (ie, the bits after the number mark supported features).

[tianon]

Lots of little nits, but overall I'm a fan. 👍

[SvenDowideit]

I'm a big fan :)

[nathanleclaire]

Nice revised with the feedback from review. @SvenDowideit@tianon PTAL

[tianon]

Can you add console here so we get nice highlights? 👼

ie:

$ command hereoutput here

[nathanleclaire]

Definitely!

[tianon]

LGTM

[daghack]

LGTM