Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339

Merged
tianon merged 2 commits into
boot2docker:masterfrom
databus23:enterprise_isourl
Feb 13, 2015
Merged

Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom
databus23:enterprise_isourl

Conversation

@databus23

@databus23databus23 commented Feb 5, 2015

Copy link
Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.

So this makes the reggae to match

  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases

Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.

Cheers

@tianon

tianon commented Feb 5, 2015

Copy link
Copy Markdown
Contributor

This seems reasonable to me.

@ehazlett@bfirsh probably something that ought to be considered for Machine too?

tianon
tianon reviewed Feb 5, 2015
View reviewed changes
Comment threadcmds.go Outdated

@tianontianonFeb 5, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?

@databus23databus23Feb 6, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done

@databus23

databus23 commented Feb 13, 2015

Copy link
Copy Markdown
Author

@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.

@tianon

tianon commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

The Travis failure will be fixed if you rebase on master. 👍

@ehazlett

ehazlett commented Feb 13, 2015

Copy link
Copy Markdown

+1 -- we will also add this to machine too.

@tianon

tianon commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

Thanks @ehazlett ❤️

LGTM

@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍

@ehazlettehazlett mentioned this pull request Feb 13, 2015
Closed
@ehazlett

ehazlett commented Feb 13, 2015

Copy link
Copy Markdown

yw

@databus23

databus23 commented Feb 13, 2015

Copy link
Copy Markdown
Author

Just rebased on master. We have a go from Travis...

@tianon

tianon commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

Thanks! 👍

tianon added a commit that referenced this pull request Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon merged commit da6f800 into boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Support github enterprise release urls for ISO by databus23 · Pull Request #339 · boot2docker/boot2docker-cli · GitHub
Skip to content

This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339
Merged
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Feb 13, 2015
Merged
Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Conversation
@databus23
@databus23databus23
commented
Feb 5, 2015

Copy link


Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.
So this makes the reggae to match
  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.
Cheers
@tianon
tianon
commented
Feb 5, 2015

Copy link


Copy Markdown

Contributor
This seems reasonable to me.
@ehazlett@bfirsh probably something that ought to be considered for Machine too?
tianon
tianon
reviewed
Feb 5, 2015
 View reviewed changes

Comment threadcmds.go
Outdated

@tianontianonFeb 5, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
@databus23databus23Feb 6, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
The Travis failure will be fixed if you rebase on master. 👍
@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

+1 -- we will also add this to machine too.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks @ehazlett ❤️
LGTM
@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍
@ehazlettehazlett
mentioned this pull request
Feb 13, 2015

Closed

@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

yw
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
Just rebased on master. We have a go from Travis...
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks! 👍
tianon added a commit
that referenced
this pull request
Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon
merged commit da6f800
into
boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support github enterprise release urls for ISO by databus23 · Pull Request #339 · boot2docker/boot2docker-cli · GitHub
Skip to content

This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339
Merged
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Feb 13, 2015
Merged
Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Conversation
@databus23
@databus23databus23
commented
Feb 5, 2015

Copy link


Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.
So this makes the reggae to match
  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.
Cheers
@tianon
tianon
commented
Feb 5, 2015

Copy link


Copy Markdown

Contributor
This seems reasonable to me.
@ehazlett@bfirsh probably something that ought to be considered for Machine too?
tianon
tianon
reviewed
Feb 5, 2015
 View reviewed changes

Comment threadcmds.go
Outdated

@tianontianonFeb 5, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
@databus23databus23Feb 6, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
The Travis failure will be fixed if you rebase on master. 👍
@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

+1 -- we will also add this to machine too.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks @ehazlett ❤️
LGTM
@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍
@ehazlettehazlett
mentioned this pull request
Feb 13, 2015

Closed

@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

yw
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
Just rebased on master. We have a go from Travis...
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks! 👍
tianon added a commit
that referenced
this pull request
Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon
merged commit da6f800
into
boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support github enterprise release urls for ISO by databus23 · Pull Request #339 · boot2docker/boot2docker-cli · GitHub
Skip to content

This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339
Merged
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Feb 13, 2015
Merged
Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Conversation
@databus23
@databus23databus23
commented
Feb 5, 2015

Copy link


Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.
So this makes the reggae to match
  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.
Cheers
@tianon
tianon
commented
Feb 5, 2015

Copy link


Copy Markdown

Contributor
This seems reasonable to me.
@ehazlett@bfirsh probably something that ought to be considered for Machine too?
tianon
tianon
reviewed
Feb 5, 2015
 View reviewed changes

Comment threadcmds.go
Outdated

@tianontianonFeb 5, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
@databus23databus23Feb 6, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
The Travis failure will be fixed if you rebase on master. 👍
@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

+1 -- we will also add this to machine too.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks @ehazlett ❤️
LGTM
@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍
@ehazlettehazlett
mentioned this pull request
Feb 13, 2015

Closed

@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

yw
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
Just rebased on master. We have a go from Travis...
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks! 👍
tianon added a commit
that referenced
this pull request
Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon
merged commit da6f800
into
boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Support github enterprise release urls for ISO by databus23 · Pull Request #339 · boot2docker/boot2docker-cli · GitHub
Skip to content

This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339
Merged
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Feb 13, 2015
Merged
Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Conversation
@databus23
@databus23databus23
commented
Feb 5, 2015

Copy link


Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.
So this makes the reggae to match
  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.
Cheers
@tianon
tianon
commented
Feb 5, 2015

Copy link


Copy Markdown

Contributor
This seems reasonable to me.
@ehazlett@bfirsh probably something that ought to be considered for Machine too?
tianon
tianon
reviewed
Feb 5, 2015
 View reviewed changes

Comment threadcmds.go
Outdated

@tianontianonFeb 5, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
@databus23databus23Feb 6, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
The Travis failure will be fixed if you rebase on master. 👍
@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

+1 -- we will also add this to machine too.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks @ehazlett ❤️
LGTM
@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍
@ehazlettehazlett
mentioned this pull request
Feb 13, 2015

Closed

@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

yw
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
Just rebased on master. We have a go from Travis...
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks! 👍
tianon added a commit
that referenced
this pull request
Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon
merged commit da6f800
into
boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support github enterprise release urls for ISO by databus23 · Pull Request #339 · boot2docker/boot2docker-cli · GitHub
Skip to content

This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339
Merged
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Feb 13, 2015
Merged
Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Conversation
@databus23
@databus23databus23
commented
Feb 5, 2015

Copy link


Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.
So this makes the reggae to match
  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.
Cheers
@tianon
tianon
commented
Feb 5, 2015

Copy link


Copy Markdown

Contributor
This seems reasonable to me.
@ehazlett@bfirsh probably something that ought to be considered for Machine too?
tianon
tianon
reviewed
Feb 5, 2015
 View reviewed changes

Comment threadcmds.go
Outdated

@tianontianonFeb 5, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
@databus23databus23Feb 6, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
The Travis failure will be fixed if you rebase on master. 👍
@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

+1 -- we will also add this to machine too.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks @ehazlett ❤️
LGTM
@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍
@ehazlettehazlett
mentioned this pull request
Feb 13, 2015

Closed

@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

yw
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
Just rebased on master. We have a go from Travis...
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks! 👍
tianon added a commit
that referenced
this pull request
Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon
merged commit da6f800
into
boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Support github enterprise release urls for ISO by databus23 · Pull Request #339 · boot2docker/boot2docker-cli · GitHub
Skip to content

This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Support github enterprise release urls for ISO - #339
Merged
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Feb 13, 2015
Merged
Support github enterprise release urls for ISO#339
tianon merged 2 commits into
boot2docker:masterfrom 
databus23:enterprise_isourl
Conversation
@databus23
@databus23databus23
commented
Feb 5, 2015

Copy link


Copy Markdown

This adds support for ISOURL pointing to GitHub Enterprise release API urls.
So this makes the reggae to match
  • https://api.github.com/repos/$ORG/$REPO/releases
  • https://some.host/api/v3/$ORG/$REPO/releases
Background: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the boot2docker download and boot2docker upgrade work for us would be a blast.
Cheers
@tianon
tianon
commented
Feb 5, 2015

Copy link


Copy Markdown

Contributor
This seems reasonable to me.
@ehazlett@bfirsh probably something that ought to be considered for Machine too?
tianon
tianon
reviewed
Feb 5, 2015
 View reviewed changes

Comment threadcmds.go
Outdated

@tianontianonFeb 5, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
@databus23databus23Feb 6, 2015

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
The Travis failure will be fixed if you rebase on master. 👍
@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

+1 -- we will also add this to machine too.
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks @ehazlett ❤️
LGTM
@databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍
@ehazlettehazlett
mentioned this pull request
Feb 13, 2015

Closed

@ehazlett
ehazlett
commented
Feb 13, 2015

Copy link


Copy Markdown

yw
@databus23
databus23
commented
Feb 13, 2015

Copy link


Copy Markdown

Author
Just rebased on master. We have a go from Travis...
@tianon
tianon
commented
Feb 13, 2015

Copy link


Copy Markdown

Contributor
Thanks! 👍
tianon added a commit
that referenced
this pull request
Feb 13, 2015
@tianon
Merge pull request#339from databus23/enterprise_isourl
da6f800
Support github enterprise release urls for ISO
@tianon
tianon
merged commit da6f800
into
boot2docker:masterFeb 13, 2015
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@databus23@tianon@ehazlett