') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix shellinit output for cmd.exe/powershell by ahmetb · Pull Request #356 · boot2docker/boot2docker-cli · GitHub
Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

Fix shellinit output for cmd.exe/powershell - #356

Merged
tianon merged 1 commit into
boot2docker:masterfrom
ahmetb:shellinit-fix
Mar 26, 2015
Merged

Fix shellinit output for cmd.exe/powershell#356
tianon merged 1 commit into
boot2docker:masterfrom
ahmetb:shellinit-fix

Conversation

@ahmetb

@ahmetbahmetb commented Mar 25, 2015

Copy link
Copy Markdown
Contributor

Also fixes the issue with Windows paths with backslashes in the bash
export statements.

When shellinit/up executed on windows, prints instructions on how to set
environment variables correctly for Windows Command Prompt (cmd.exe) and
PowerShell. (only the powershell set path statements are printed to
stdout; the rest goes to stderr).

We couldn't find a way to figure out if we're running on CMD or PowerShell, that's
why printing instructions for both.

Visualized:

Changes in MSYS window (used with "Boot2Docker Start" shortcut link), added single quotes around path.

CMD.exe output for for up (used to print "Docker client does not run on Windows for now"):

Powershell output for up (same as cmd.exe):

Powershell boot2docker shellinit | Invoke-Expression (notice that the PS commands are missing as they were on stdout and got piped to Invoke-Expression):

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @tianon@johngossman

@ahmetbahmetb mentioned this pull request Mar 25, 2015
Closed
9 tasks
@tianon

tianon commented Mar 25, 2015

Copy link
Copy Markdown
Contributor

A tiny bit hacky, but not unreasonably so. 👍

LGTM

cc @Moghedrin @gmlewis

gmlewis
gmlewis reviewed Mar 25, 2015
View reviewed changes
Comment threadcmds.go Outdated

@gmlewisgmlewisMar 25, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could be:

fmt.Fprintln(os.Stderr, `to your shell or run "boot2docker shellinit | Invoke-Expression" to set the`)

@ahmetb
Fix shellinit output for cmd.exe/powershell
b215553
Also fixes the issue with Windows paths with backslashes in the bash
`export` statements.
When shellinit/up executed on windows, prints instructions on how to set
environment variables correctly for Windows Command Prompt (cmd.exe) and
PowerShell. (only the powershell set path statements are printed to
stdout; the rest goes to stderr).
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@gmlewis

gmlewis commented Mar 25, 2015

Copy link
Copy Markdown
Contributor

A couple minor nits, otherwise LGTM.

tianon added a commit that referenced this pull request Mar 26, 2015
@tianon
Merge pull request#356from ahmetalpbalkan/shellinit-fix
63bf6b5
Fix shellinit output for cmd.exe/powershell
@tianon
tianon merged commit 63bf6b5 into boot2docker:masterMar 26, 2015
@ahmetbahmetb mentioned this pull request Mar 28, 2015
Closed
@ahmetbahmetb mentioned this pull request Apr 14, 2015
Closed
@ahmetb
ahmetb deleted the shellinit-fix branch April 14, 2015 06:39
This was referenced Jun 7, 2015
Closed
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmetb@tianon@gmlewis