Skip to content

fix bash completion install command#189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-fleming wants to merge 1 commit into
base:main
Choose a base branch
from
Open

fix bash completion install command #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions cmd/root.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,6 +31,7 @@ func Execute(currentVersion string) error {
info := version.FetchUpdateInfo(rootCmd.Version)
defer info.PromptUpdateIfAvailable()
ctx := version.WithContext(context.Background(), &info)
patchBashCompletionHelp()
return rootCmd.ExecuteContext(ctx)
}

Expand DownExpand Up@@ -194,3 +195,21 @@ func requireAuth(cmd *cobra.Command, args []string) {
err = viper.WriteConfig()
promptLoginAndExitIf(err != nil)
}

// patchBashCompletionHelp adjusts Cobra's generated bash completion help.
//
// Cobra's default Linux example redirects into /etc/bash_completion.d, which
// fails for non-root shells. Use sudo tee so only the file write is elevated.
func patchBashCompletionHelp() {
rootCmd.InitDefaultCompletionCmd()

bashCmd, _, err := rootCmd.Find([]string{"completion", "bash"})
if err != nil || bashCmd == nil {
return
}

old := "bootdev completion bash > /etc/bash_completion.d/bootdev"
new := "bootdev completion bash | sudo tee /etc/bash_completion.d/bootdev > /dev/null"

bashCmd.Long = strings.Replace(bashCmd.Long, old, new, 1)
}