Update module github.com/redis/go-redis/v9 to v9.6.0 - #123
Merged
Conversation
bootjp added a commit
that referenced
this pull request
Apr 26, 2026
CLAUDE.md Conventions: "Don't reference the current task, fix, or callers (added for the X flow, handles the case from issue #123) since those belong in the PR description and rot as the codebase evolves." Removes four PR-attribution lines added across this PR's earlier commits: - adapter/sqs_admin.go: metaAttributesForAdmin docstring tail. - internal/admin/sqs_handler.go handleList: nil normalisation note. - internal/admin/sqs_handler.go principalForWrite: docstring tail. - main_admin.go translateAdminQueuesError: leader-churn arm note. The why-this-line-exists rationale stays in each spot; only the "Codex P2 + Claude P1 on PR #N caught the bug" sentences and the sibling-PR cross-references are dropped. Flagged as a non-blocking nit by Claude P1 on PR #670 seventh-round review (the docstring on metaAttributesForAdmin specifically); the other three are the same convention violation in adjacent code so they go in the same cleanup.
3 tasks
bootjp added a commit
that referenced
this pull request
May 15, 2026
claude[bot] round-5 verdict was "Approve" with one new P3 noting that prior commits accumulated PR-stage / round-number references in code comments (e.g. "Codex P1 round-4 finding on PR #756"). CLAUDE.md says: Don't reference the current task, fix, or callers ("used by X", "added for the Y flow", "handles the case from issue #123"), since those belong in the PR description and rot as the codebase evolves. This commit removes the PR/round provenance from every code and test comment that picked it up across rounds 1-5, while preserving the invariant-level WHY (which IS load-bearing for future readers). Files touched: - adapter/encryption_admin.go (2 sites: requireLeader, verifyLeaderErrorToStatus) - adapter/encryption_admin_test.go (6 sites: regression-test docstrings) - cmd/elastickv-admin/encryption_test.go (2 sites: help-flag test, non-precondition propagation test) No behaviour change. No tests changed structurally — only docstrings. ## Skipped (claude[bot] non-blocking observations) - ResyncSidecar context-code twin test: correctness guaranteed by the shared verifyLeaderErrorToStatus helper that the existing RotateDEK test exercises. - requireUint16Plus1 rename: cosmetic carry-forward. - localEpochMask const placement: cosmetic carry-forward. ## Verification - go test -race -timeout=60s ./adapter ./cmd/elastickv-admin: PASS - golangci-lint run on touched paths: 0 issues
4 tasks
bootjp added a commit
that referenced
this pull request
May 16, 2026
…tion from inline comments claude[bot] r3 verdict was 'all three fixes correct' but flagged 5 inline-comment sites that referenced 'PR #765 round-N reviewer-name' meta. CLAUDE.md: Don't reference the current task, fix, or callers ("used by X", "added for the Y flow", "handles the case from issue #123"), since those belong in the PR description and rot as the codebase evolves. This commit strips the attribution from all 5 sites while preserving the semantic content (why the code does what it does, separate from who flagged it). ## Sites cleaned up - internal/encryption/applier.go:107 — ApplyRegistration godoc case-2-idempotent paragraph: removed '— codex PR #765 round-2 P1'. - internal/encryption/applier.go:158-162 — case-2-idempotent inline comment: removed '(PR #765 round-2 codex P1)'. - internal/encryption/applier.go:213-217 — nodeIDMask godoc (round-2 carry-over): rewrote 'gemini-code-assist PR #765 round-1 medium flagged the original localEpochMaskU64 name as misleading at this call site' → 'the name distinguishes this FullNodeID-truncation use from the local_epoch masking in adapter/encryption_admin.go' (semantic content preserved, attribution dropped). - store/encryption_glue.go:92 — WriterRegistryFor typed-nil inline comment: removed '— coderabbit PR #765 round-2 Major'. - internal/encryption/applier_test.go:151 — TestApplyRegistration_Case2_IdempotentReplay godoc: removed '(PR #765 round-2 codex P1)'. ## Caller audit Pure comment edit — no callers to audit. Code unchanged. ## Verification - go build ./... — PASS - go test -race -timeout=60s ./internal/encryption/... ./store/... . — PASS - golangci-lint run ./internal/encryption/... ./store/... — 0 issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v9.5.4->v9.6.0Release Notes
redis/go-redis (github.com/redis/go-redis/v9)
v9.6.0: 9.6.0Changes
🚀 New Features
🛠️ Improvements
This release includes support for Redis Community Edition (CE) 7.4.0, ensuring compatibility with the latest features and improvements introduced in Redis CE 7.4.0.
🧰 Maintenance
(*StatusCmd).Bytes()method (#3030)Contributors
We'd like to thank all the contributors who worked on this release!
@LINKIWI, @b1ron, @dependabot, @dependabot[bot], @gerzse, @haines, @immersedin, @naiqianz, @ofekshenawa, @srikar-jilugu, @tzongw, @vladvildanov and @vmihailenco@monkey92t
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.