Conversation
| slog.String("value", string(req.Value)), | ||
| slog.Uint64("hash", key), | ||
| ) | ||
| //switch { |
Contributor
There was a problem hiding this comment.
🚫 [golangci]reported by reviewdog 🐶
commentFormatting: put a space between // and comment text (gocritic)
| //switch { | ||
| //case r pb.PutRequest: | ||
| f.log.InfoContext(ctx, "applied raft log", slog.String("type", "PutRequest")) | ||
| return f.store.Put(ctx, req.Key, req.Value) |
Contributor
There was a problem hiding this comment.
🚫 [golangci]reported by reviewdog 🐶
error returned from interface method should be wrapped: sig: func (github.com/bootjp/elastickv/kv.Store).Put(ctx context.Context, key []byte, value []byte) error (wrapcheck)
bootjp
enabled auto-merge
December 3, 2023 14:31
bootjp
disabled auto-merge
December 3, 2023 15:51
2 tasks
bootjp added a commit
that referenced
this pull request
May 26, 2026
Addresses the non-blocking review findings on the Stage 7a-2 implementation (no P0/P1/major were raised): - retryUntilRegistered (#1, #2): re-warn periodically (every registrationGateWarnAfter) instead of once, so a node stuck for minutes stays visible; log the ctx-cancellation (clean-shutdown) branch at INFO so a graceful restart during the bootstrap retry window reads as shutdown rather than failure. The returned error still preserves the context.Canceled chain (consistent with every other ctx-aware startup step). - verifyRegistered (#3): build the WriterRegistryFor handle once in buildProcessStartRegistrationGate and reuse it across the retry loop via the new registryLastSeen helper, instead of re-asserting + allocating a handle per call. - setupDistributionCatalog (#9): document the EnsureCatalogSnapshot idempotency requirement the retry relies on (populated-catalog path is a version-unchanged no-op Save). - Tests (#5): TestRetryUntilRegistered drives the helper through converge-after-transient-gate-error, immediate-non-gate-error, immediate-success, and ctx-cancellation paths. claude #4 (newCutoverApplier unused dir param) is a pre-existing test helper untouched by this slice; left out of scope.
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.