Skip to content

Update babel and eslint config - #17

Open
kimanijacky wants to merge 4 commits into
masterfrom
update-babel/eslint
Open

Update babel and eslint config#17
kimanijacky wants to merge 4 commits into
masterfrom
update-babel/eslint

Conversation

@kimanijacky

Copy link
Copy Markdown

Update the following packages:

  • babel-preset-metalab
  • eslint-config-metalab
  • eslint
  • eslint-plugin-babel
  • eslint-plugin-filenames
  • eslint-plugin-import
  • eslint-plugin-lodash-fp
  • eslint-plugin-react

@10xjs

10xjs commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

@andela-jkimani babel-preset-metalab 6 is a breaking change over 5. We need to update the .babelrc file with targets to ensure compatibility (babel-preset-metalab uses babel-preset-env internally) . See https://github.com/babel/babel-preset-env#targets.

@10xjs

Copy link
Copy Markdown
Contributor

@izaakschroeder What do you think is a sane browser target? "last 3 versions"? "last 4 versions"? ...

I assume we want to capture IE 8 and Safari 7 and whatever else.

Ideally this would be the same as what this lib currently supports, whatever that is exactly 😬 .

@izaakschroeder

izaakschroeder commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

Having ["> 1%"] seems reasonable to me for now. What do you figure?

@10xjs

Copy link
Copy Markdown
Contributor

It would be nice if there was a browserslist.lock since the result of ["> 1%"] is a product of when it is calculated.

@kimanijacky

Copy link
Copy Markdown
Author

@izaakschroeder So we're not targeting specific browsers? Got it!

@kimanijacky
kimanijackyforce-pushed the update-babel/eslint branch 4 times, most recently from 676fa2a to e9644a9CompareMarch 15, 2017 20:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kimanijacky@10xjs@izaakschroeder