Uh oh!
There was an error while loading. Please reload this page.
Remove conditional on environment - #794
Merged
lcreid merged 1 commit intoApr 22, 2026
Merged
Conversation
lcreidforce-pushed
the
792/remove-conditional-on-environment
branch
from
April 22, 2026 21:27
2006d81 to
1630f48CompareUh oh!
There was an error while loading. Please reload this page.
pablobm
commented
Apr 23, 2026
lcreid
commented
Apr 23, 2026
ContributorAuthor
Yes, it makes sense to me that we should be more compliant with ARIA by default, but we're sensitive to not breaking existing users' pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#779 introduced a configuration option, that for some reason defaulted differently in development than in production. This was not good. This PR makes the configuration option the same across environments.
Closes: #792